list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Philip Oakley <>
To: Junio C Hamano <>
Cc: Elijah Newren <>,
	Denton Liu <>,
	Viresh Kumar <>,
	Git Mailing List <>,
Subject: Re: [Bug report] git diff stat shows unrelated diff
Date: Sat, 16 Feb 2019 12:47:52 +0000
Message-ID: <> (raw)
In-Reply-To: <>

On 15/02/2019 23:32, Junio C Hamano wrote:
> Philip Oakley <> writes:
>> On 15/02/2019 20:12, Junio C Hamano wrote:
>>> Historically, it was a mistake to allow A..B to be used for two
>>> endpoints, which was made back when we haven't thought things
>>> through.  That is why I stopped "warn to deprecate and then
>>> completely remove", as I do not think it would help people very much
>>> if "git diff A B" can be spelled with two-dots.
>>> But in a distant future long after that happens, by the time nobody
>>> remembers what A..B meant for "git diff", I do not think I'd
>>> strongly be opposed to reusing it to mean something different.
>> Would an option be to add a opt-in config to do the warning, rather
>> than start immediately at a deprecation warning?
> Well, anything would be "an option".  I am not sure it would be
> particularly a good option to allow people to "opt" into getting
> warned, only to get a chance to train their fingers not to type
> double-dot instead of a SP, earlier than other people, though.
The point of the suggestion was very much to provide users with the 
choice of finger training at their own time and pace, rather than being 
forced by the deprecation sequence to be surprised at an inconvenient 
time into having to respond.
>> It would give users the chance to test out their usage early should
>> the so wish/desire/notice.
> I am somewhat puzzled.  What are you trying to achieve by that?
> Those who do *not* opt into that "early warning" configuration dance
> would eventually be warned whenever they type "diff A..B", and the
> timing for that eventuality is not under their control, so quite
> honestly, I do not see much point in "giving users the chance".

With the opposite hat on, not giving users the choice does seem unfair 
to those that are trying to keep up. If we are warning (in the release 
notes) of an upcoming deprecation (in the code) then it does seem 
helpful that users could buy into the deprecation early, and at their 
convenience, to assist in the unlearning of an old habit, which can be 
much harder than learning a new habit, hence my comment.

You are right that those who neither notice nor care will be surprised 
later, but we shouldn't let that limit others.



  reply	other threads:[~2019-02-16 12:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14  8:22 Viresh Kumar
2019-02-14 18:42 ` Johannes Sixt
2019-02-14 21:23 ` Elijah Newren
2019-02-14 22:10   ` Junio C Hamano
2019-02-15 18:52     ` Denton Liu
2019-02-15 19:25       ` Elijah Newren
2019-02-15 20:12         ` Junio C Hamano
2019-02-15 22:48           ` Philip Oakley
2019-02-15 23:32             ` Junio C Hamano
2019-02-16 12:47               ` Philip Oakley [this message]
2019-02-17  3:34                 ` Junio C Hamano
2019-02-17 23:34                   ` Philip Oakley
2019-02-18  0:21                     ` Junio C Hamano
2019-02-15 19:28       ` Junio C Hamano
2019-02-15  6:40   ` Viresh Kumar
2019-02-15 16:09     ` Elijah Newren
2019-02-18  4:34       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for the project(s) associated with this inbox:

AGPL code for this site: git clone