From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.org>
Cc: Elijah Newren <newren@gmail.com>,
Denton Liu <liu.denton@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Git Mailing List <git@vger.kernel.org>,
vincent.guittot@linaro.org
Subject: Re: [Bug report] git diff stat shows unrelated diff
Date: Fri, 15 Feb 2019 15:32:20 -0800 [thread overview]
Message-ID: <xmqqr2c84ohn.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <ad85402e-0ad2-4f4d-3b66-9250115072c0@iee.org> (Philip Oakley's message of "Fri, 15 Feb 2019 22:48:40 +0000")
Philip Oakley <philipoakley@iee.org> writes:
> On 15/02/2019 20:12, Junio C Hamano wrote:
>>
>> Historically, it was a mistake to allow A..B to be used for two
>> endpoints, which was made back when we haven't thought things
>> through. That is why I stopped "warn to deprecate and then
>> completely remove", as I do not think it would help people very much
>> if "git diff A B" can be spelled with two-dots.
>>
>> But in a distant future long after that happens, by the time nobody
>> remembers what A..B meant for "git diff", I do not think I'd
>> strongly be opposed to reusing it to mean something different.
>
> Would an option be to add a opt-in config to do the warning, rather
> than start immediately at a deprecation warning?
Well, anything would be "an option". I am not sure it would be
particularly a good option to allow people to "opt" into getting
warned, only to get a chance to train their fingers not to type
double-dot instead of a SP, earlier than other people, though.
> It would give users the chance to test out their usage early should
> the so wish/desire/notice.
I am somewhat puzzled. What are you trying to achieve by that?
Those who do *not* opt into that "early warning" configuration dance
would eventually be warned whenever they type "diff A..B", and the
timing for that eventuality is not under their control, so quite
honestly, I do not see much point in "giving users the chance".
next prev parent reply other threads:[~2019-02-15 23:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 8:22 [Bug report] git diff stat shows unrelated diff Viresh Kumar
2019-02-14 18:42 ` Johannes Sixt
2019-02-14 21:23 ` Elijah Newren
2019-02-14 22:10 ` Junio C Hamano
2019-02-15 18:52 ` Denton Liu
2019-02-15 19:25 ` Elijah Newren
2019-02-15 20:12 ` Junio C Hamano
2019-02-15 22:48 ` Philip Oakley
2019-02-15 23:32 ` Junio C Hamano [this message]
2019-02-16 12:47 ` Philip Oakley
2019-02-17 3:34 ` Junio C Hamano
2019-02-17 23:34 ` Philip Oakley
2019-02-18 0:21 ` Junio C Hamano
2019-02-15 19:28 ` Junio C Hamano
2019-02-15 6:40 ` Viresh Kumar
2019-02-15 16:09 ` Elijah Newren
2019-02-18 4:34 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2c84ohn.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=newren@gmail.com \
--cc=philipoakley@iee.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).