From: Junio C Hamano <email@example.com> To: Elijah Newren <firstname.lastname@example.org> Cc: Viresh Kumar <email@example.com>, Git Mailing List <firstname.lastname@example.org>, email@example.com Subject: Re: [Bug report] git diff stat shows unrelated diff Date: Thu, 14 Feb 2019 14:10:53 -0800 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CABPp-BGstumw1eyZ++0itk-AR0Bk5zd0AchgznBpMq35a6ScUg@mail.gmail.com> (Elijah Newren's message of "Thu, 14 Feb 2019 13:23:14 -0800") Elijah Newren <email@example.com> writes: > The only thing I seem to be able to retain is the following: "git > diff D..E is totally useless and should be an error because (1) it > doesn't do what I expect and (2) for folks that want the behavior > currently gotten with that syntax can instead just use a space instead > of a double dot." That sums up pretty nicely. diff is fundamentally an operation between two endpoints, so the range notation a..b does not work nicely with it at the conceptual level. When we realized that we can take advantage of the above fact, and reuse a range notation to mean something that is generally useful in the context of diff, such as 'one end of the comparison is the merge base between a and b, and the other end is b', it was too late to use "a..b", as an early adopters of Git was already used to the fact that "a..b" happened to mean the same thing as "comparison of one end is a, the other end is b", pretty much implemented without much thought. It might be _possible_ to spend a year (i.e. 4 cycles) to start warning when two-dot notation is used for "git diff" (only, not any plumbing like "git diff-files") and tell the user to use the more logical two-end notation "git diff A B" and then eventually error out when two-dot notation is used, while retaining the three-dot notation throughout and to the eternity. I am not sure if it is worth the deprecation cost, though.
next prev parent reply index Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-14 8:22 Viresh Kumar 2019-02-14 18:42 ` Johannes Sixt 2019-02-14 21:23 ` Elijah Newren 2019-02-14 22:10 ` Junio C Hamano [this message] 2019-02-15 18:52 ` Denton Liu 2019-02-15 19:25 ` Elijah Newren 2019-02-15 20:12 ` Junio C Hamano 2019-02-15 22:48 ` Philip Oakley 2019-02-15 23:32 ` Junio C Hamano 2019-02-16 12:47 ` Philip Oakley 2019-02-17 3:34 ` Junio C Hamano 2019-02-17 23:34 ` Philip Oakley 2019-02-18 0:21 ` Junio C Hamano 2019-02-15 19:28 ` Junio C Hamano 2019-02-15 6:40 ` Viresh Kumar 2019-02-15 16:09 ` Elijah Newren 2019-02-18 4:34 ` Viresh Kumar
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
firstname.lastname@example.org list mirror (unofficial, one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git