From: Johannes Sixt <j6t@kdbg.org>
To: Shubham Mishra <shivam828787@gmail.com>
Cc: me@ttaylorr.com, kaartic.sivaraam@gmail.com, git@vger.kernel.org
Subject: Re: [GSoC] [PATCH v3 0/2] avoid pipes with Git on LHS
Date: Sat, 12 Mar 2022 10:05:07 +0100 [thread overview]
Message-ID: <d13532cb-4f7d-d211-ff5c-26f90bd1c859@kdbg.org> (raw)
In-Reply-To: <20220312062126.31988-1-shivam828787@gmail.com>
Am 12.03.22 um 07:21 schrieb Shubham Mishra:
> changes since v2:
> * t0000: remove git command out of subshell
> * t0030: fix missing redirections to "tmp" file
> Shubham Mishra (2):
> t0001-t0028: avoid pipes with Git on LHS
> t0030-t0050: avoid pipes with Git on LHS
>
> t/t0000-basic.sh | 10 +++--
> t/t0022-crlf-rename.sh | 4 +-
> t/t0025-crlf-renormalize.sh | 4 +-
> t/t0027-auto-crlf.sh | 12 +++---
> t/t0030-stripspace.sh | 75 ++++++++++++++++++++++++-------------
> t/t0050-filesystem.sh | 3 +-
> 6 files changed, 66 insertions(+), 42 deletions(-)
>
> Range-diff against v2:
> 1: 2a219ace42 ! 1: 5e122c0acf t0001-t0028: avoid pipes with Git on LHS
> @@ t/t0000-basic.sh: test_expect_success 'update-index D/F conflict' '
> '
>
> @@ t/t0000-basic.sh: test_expect_success 'very long name in the index handled sanely' '
> +
> >path4 &&
> git update-index --add path4 &&
> ++ git ls-files -s path4 >tmp &&
> (
> - git ls-files -s path4 |
> - sed -e "s/ .*/ /" |
> -+ git ls-files -s path4 >tmp &&
> + sed -e "s/ .*/ /" tmp |
> tr -d "\012" &&
> echo "$a"
> 2: c90fc271d9 ! 2: c412380af3 t0030-t0050: avoid pipes with Git on LHS
> @@ t/t0030-stripspace.sh: test_expect_success \
> - ! (printf "$ttt$sss$sss$sss" | git stripspace | grep " " >/dev/null)
> + printf "$ttt$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
> -+ printf "$ttt$ttt$sss" | git stripspace &&
> ++ printf "$ttt$ttt$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
> -+ printf "$ttt$ttt$ttt$sss" | git stripspace &&
> ++ printf "$ttt$ttt$ttt$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
> -+ printf "$ttt$sss$sss" | git stripspace &&
> ++ printf "$ttt$sss$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
> -+ printf "$ttt$ttt$sss$sss" | git stripspace &&
> ++ printf "$ttt$ttt$sss$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
> -+ printf "$ttt$sss$sss$sss" | git stripspace &&
> ++ printf "$ttt$sss$sss$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null
> '
>
> @@ t/t0030-stripspace.sh: test_expect_success \
> + echo "$ttt$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
> + echo "$ttt$ttt$sss" | git stripspace >tmp &&
> -+ ! grep " " tmp>/dev/null &&
> -+ echo "$ttt$ttt$ttt$sss" &&
> ++ ! grep " " tmp >/dev/null &&
> ++ echo "$ttt$ttt$ttt$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
> + echo "$ttt$sss$sss" | git stripspace >tmp &&
> + ! grep " " tmp >/dev/null &&
This round addresses all my comments. Thanks!
-- Hannes
next prev parent reply other threads:[~2022-03-12 9:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 5:47 [PATCH 0/2] Subject: [PATCH 0/2] [GSoC][PATCH 0/2] t0000-t0050: avoid pipes with Git on LHS Shubham Mishra
2022-02-24 5:47 ` [PATCH 1/2] t0001-t0028: " Shubham Mishra
2022-02-24 5:47 ` [PATCH 2/2] t0030-t0050: " Shubham Mishra
2022-02-24 8:59 ` Ævar Arnfjörð Bjarmason
2022-02-26 12:09 ` Shubham Mishra
2022-02-26 17:32 ` Taylor Blau
2022-02-27 12:24 ` [GSoC] [PATCH v2 0/2] " Shubham Mishra
2022-02-27 12:24 ` [PATCH v2 1/2] t0001-t0028: " Shubham Mishra
2022-02-27 17:43 ` Johannes Sixt
2022-03-03 12:48 ` Shubham Mishra
2022-02-27 12:24 ` [PATCH v2 2/2] t0030-t0050: " Shubham Mishra
2022-02-27 17:52 ` Johannes Sixt
2022-02-24 5:51 ` [PATCH 0/2] Subject: [PATCH 0/2] [GSoC][PATCH 0/2] t0000-t0050: " Shubham Mishra
2022-02-26 17:30 ` Taylor Blau
2022-03-12 6:21 ` [GSoC] [PATCH v3 0/2] " Shubham Mishra
2022-03-12 6:21 ` [PATCH v3 1/2] t0001-t0028: " Shubham Mishra
2022-03-12 6:21 ` [PATCH v3 2/2] t0030-t0050: " Shubham Mishra
2022-03-12 9:05 ` Johannes Sixt [this message]
2022-03-12 10:27 ` [GSoC] [PATCH v3 0/2] " Shubham Mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d13532cb-4f7d-d211-ff5c-26f90bd1c859@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=me@ttaylorr.com \
--cc=shivam828787@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).