From: Johannes Sixt <j6t@kdbg.org>
To: Shubham Mishra <shivam828787@gmail.com>
Cc: me@ttaylorr.com, avarab@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v2 1/2] t0001-t0028: avoid pipes with Git on LHS
Date: Sun, 27 Feb 2022 18:43:03 +0100 [thread overview]
Message-ID: <177b8b40-9e27-5019-c4df-772642508c37@kdbg.org> (raw)
In-Reply-To: <20220227122453.25278-2-shivam828787@gmail.com>
Am 27.02.22 um 13:24 schrieb Shubham Mishra:
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index b007f0efef..b5fa76059b 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -1104,12 +1105,13 @@ test_expect_success 'very long name in the index handled sanely' '
> >path4 &&
> git update-index --add path4 &&
> (
> - git ls-files -s path4 |
> - sed -e "s/ .*/ /" |
> + git ls-files -s path4 >tmp &&
> + sed -e "s/ .*/ /" tmp |
> tr -d "\012" &&
> echo "$a"
> ) | git update-index --index-info &&
We see a pipe here, and in the upstream of that pipe is a git
invocation. That should be fixed, too. After the rewrite that you
already did here, it should be sufficient to move the git invocation
before the parentheses.
> - len=$(git ls-files "a*" | wc -c) &&
> + git ls-files "a*" >tmp &&
> + len=$(wc -c <tmp) &&
> test $len = 4098
> '
-- Hannes
next prev parent reply other threads:[~2022-02-27 17:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 5:47 [PATCH 0/2] Subject: [PATCH 0/2] [GSoC][PATCH 0/2] t0000-t0050: avoid pipes with Git on LHS Shubham Mishra
2022-02-24 5:47 ` [PATCH 1/2] t0001-t0028: " Shubham Mishra
2022-02-24 5:47 ` [PATCH 2/2] t0030-t0050: " Shubham Mishra
2022-02-24 8:59 ` Ævar Arnfjörð Bjarmason
2022-02-26 12:09 ` Shubham Mishra
2022-02-26 17:32 ` Taylor Blau
2022-02-27 12:24 ` [GSoC] [PATCH v2 0/2] " Shubham Mishra
2022-02-27 12:24 ` [PATCH v2 1/2] t0001-t0028: " Shubham Mishra
2022-02-27 17:43 ` Johannes Sixt [this message]
2022-03-03 12:48 ` Shubham Mishra
2022-02-27 12:24 ` [PATCH v2 2/2] t0030-t0050: " Shubham Mishra
2022-02-27 17:52 ` Johannes Sixt
2022-02-24 5:51 ` [PATCH 0/2] Subject: [PATCH 0/2] [GSoC][PATCH 0/2] t0000-t0050: " Shubham Mishra
2022-02-26 17:30 ` Taylor Blau
2022-03-12 6:21 ` [GSoC] [PATCH v3 0/2] " Shubham Mishra
2022-03-12 6:21 ` [PATCH v3 1/2] t0001-t0028: " Shubham Mishra
2022-03-12 6:21 ` [PATCH v3 2/2] t0030-t0050: " Shubham Mishra
2022-03-12 9:05 ` [GSoC] [PATCH v3 0/2] " Johannes Sixt
2022-03-12 10:27 ` Shubham Mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177b8b40-9e27-5019-c4df-772642508c37@kdbg.org \
--to=j6t@kdbg.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=shivam828787@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).