[GSoC] [PATCH v2 0/2] avoid pipes with Git on LHS

git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed

From: Shubham Mishra <shivam828787@gmail.com>
To: git@vger.kernel.org
Cc: me@ttaylorr.com, avarab@gmail.com,
	Shubham Mishra <shivam828787@gmail.com>
Subject: [GSoC] [PATCH v2 0/2] avoid pipes with Git on LHS
Date: Sun, 27 Feb 2022 17:54:51 +0530	[thread overview]
Message-ID: <20220227122453.25278-1-shivam828787@gmail.com> (raw)
In-Reply-To: <220224.86o82wab31.gmgdl@evledraar.gmail.com>

changes since v1:
* replaced "wc -l" with test_stdout_line_count 
* removed unnecessary "()" subshells

Shubham Mishra (2):
  t0001-t0028: avoid pipes with Git on LHS
  t0030-t0050: avoid pipes with Git on LHS

 t/t0000-basic.sh            | 10 +++--
 t/t0022-crlf-rename.sh      |  4 +-
 t/t0025-crlf-renormalize.sh |  4 +-
 t/t0027-auto-crlf.sh        | 12 +++---
 t/t0030-stripspace.sh       | 75 ++++++++++++++++++++++++-------------
 t/t0050-filesystem.sh       |  3 +-
 6 files changed, 66 insertions(+), 42 deletions(-)

Range-diff against v1:
1:  2a219ace42 = 1:  2a219ace42 t0001-t0028: avoid pipes with Git on LHS
2:  d08c144476 ! 2:  c90fc271d9 t0030-t0050: avoid pipes with Git on LHS
    @@ Commit message
         Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
     
      ## t/t0030-stripspace.sh ##
    +@@ t/t0030-stripspace.sh: s40='                                        '
    + sss="$s40$s40$s40$s40$s40$s40$s40$s40$s40$s40" # 400
    + ttt="$t40$t40$t40$t40$t40$t40$t40$t40$t40$t40" # 400
    + 
    ++printf_git_stripspace () {
    ++    printf "$1" | git stripspace
    ++}
    ++
    + test_expect_success \
    +     'long lines without spaces should be unchanged' '
    +     echo "$ttt" >expect &&
     @@ t/t0030-stripspace.sh: test_expect_success \
      
      test_expect_success \
    @@ t/t0030-stripspace.sh: test_expect_success \
     -    test $(printf "$ttt$ttt" | git stripspace | wc -l) -gt 0 &&
     -    test $(printf "$ttt$ttt$ttt" | git stripspace | wc -l) -gt 0 &&
     -    test $(printf "$ttt$ttt$ttt$ttt" | git stripspace | wc -l) -gt 0
    -+    printf "$ttt" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$ttt" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$ttt$ttt" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$ttt$ttt$ttt" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$ttt" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$ttt$ttt" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$ttt$ttt$ttt"
      '
      
      # text plus spaces at the end:
    @@ t/t0030-stripspace.sh: test_expect_success \
     -    test $(printf "$ttt$sss$sss" | git stripspace | wc -l) -gt 0 &&
     -    test $(printf "$ttt$ttt$sss$sss" | git stripspace | wc -l) -gt 0 &&
     -    test $(printf "$ttt$sss$sss$sss" | git stripspace | wc -l) -gt 0
    -+    printf "$ttt$sss" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$ttt$sss" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$ttt$ttt$sss" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$sss$sss" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$ttt$sss$sss" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0 &&
    -+    printf "$ttt$sss$sss$sss" | git stripspace >tmp &&
    -+    test $(wc -l <tmp) -gt 0
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$sss" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$ttt$sss" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$ttt$ttt$sss" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$sss$sss" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$ttt$sss$sss" &&
    ++    test_stdout_line_count -gt 0 printf_git_stripspace "$ttt$sss$sss$sss"
      '
      
      test_expect_success \
    @@ t/t0030-stripspace.sh: test_expect_success \
     -    ! (printf "$ttt$ttt$sss$sss" | git stripspace | grep "  " >/dev/null) &&
     -    ! (printf "$ttt$sss$sss$sss" | git stripspace | grep "  " >/dev/null)
     +    printf "$ttt$sss" | git stripspace >tmp &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    printf "$ttt$ttt$sss" | git stripspace &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    printf "$ttt$ttt$ttt$sss" | git stripspace &&
    -+    ! (grep "  " tmp >/dev/nul) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    printf "$ttt$sss$sss" | git stripspace &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    printf "$ttt$ttt$sss$sss" | git stripspace &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    printf "$ttt$sss$sss$sss" | git stripspace &&
    -+    ! (grep "  " tmp >/dev/null)
    ++    ! grep "  " tmp >/dev/null
      '
      
      test_expect_success \
    @@ t/t0030-stripspace.sh: test_expect_success \
     -    ! (echo "$ttt$ttt$sss$sss" | git stripspace | grep "  " >/dev/null) &&
     -    ! (echo "$ttt$sss$sss$sss" | git stripspace | grep "  " >/dev/null)
     +    echo "$ttt$sss" | git stripspace >tmp &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    echo "$ttt$ttt$sss" | git stripspace >tmp &&
    -+    ! (grep "  " tmp>/dev/null) &&
    ++    ! grep "  " tmp>/dev/null &&
     +    echo "$ttt$ttt$ttt$sss" &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    echo "$ttt$sss$sss" | git stripspace >tmp &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    echo "$ttt$ttt$sss$sss" | git stripspace >tmp &&
    -+    ! (grep "  " tmp >/dev/null) &&
    ++    ! grep "  " tmp >/dev/null &&
     +    echo "$ttt$sss$sss$sss" | git stripspace >tmp &&
    -+    ! (grep "  " tmp >/dev/null)
    ++    ! grep "  " tmp >/dev/null
      '
      
      test_expect_success \
    @@ t/t0030-stripspace.sh: test_expect_success \
     -    ! (printf "$sss$sss$sss" | git stripspace | grep " " >/dev/null) &&
     -    ! (printf "$sss$sss$sss$sss" | git stripspace | grep " " >/dev/null)
     +    printf "" | git stripspace >tmp &&
    -+    ! ( grep " " tmp >/dev/null) &&
    ++    ! grep " " tmp >/dev/null &&
     +    printf "$sss" | git stripspace >tmp &&
    -+    ! ( grep " " tmp >/dev/null) &&
    ++    ! grep " " tmp >/dev/null &&
     +    printf "$sss$sss" | git stripspace >tmp &&
    -+    ! (grep " " tmp >/dev/null) &&
    ++    ! grep " " tmp >/dev/null &&
     +    printf "$sss$sss$sss" | git stripspace >tmp &&
    -+    ! (grep " " tmp >/dev/null) &&
    ++    ! grep " " tmp >/dev/null &&
     +    printf "$sss$sss$sss$sss" | git stripspace >tmp &&
    -+    ! (grep " " tmp >/dev/null)
    ++    ! grep " " tmp >/dev/null
      '
      
      test_expect_success \
-- 
2.25.1

next prev parent reply	other threads:[~2022-02-27 12:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24  5:47 [PATCH 0/2] Subject: [PATCH 0/2] [GSoC][PATCH 0/2] t0000-t0050: avoid pipes with Git on LHS Shubham Mishra
2022-02-24  5:47 ` [PATCH 1/2] t0001-t0028: " Shubham Mishra
2022-02-24  5:47 ` [PATCH 2/2] t0030-t0050: " Shubham Mishra
2022-02-24  8:59   ` Ævar Arnfjörð Bjarmason
2022-02-26 12:09     ` Shubham Mishra
2022-02-26 17:32     ` Taylor Blau
2022-02-27 12:24     ` Shubham Mishra [this message]
2022-02-27 12:24       ` [PATCH v2 1/2] t0001-t0028: " Shubham Mishra
2022-02-27 17:43         ` Johannes Sixt
2022-03-03 12:48           ` Shubham Mishra
2022-02-27 12:24       ` [PATCH v2 2/2] t0030-t0050: " Shubham Mishra
2022-02-27 17:52         ` Johannes Sixt
2022-02-24  5:51 ` [PATCH 0/2] Subject: [PATCH 0/2] [GSoC][PATCH 0/2] t0000-t0050: " Shubham Mishra
2022-02-26 17:30   ` Taylor Blau
2022-03-12  6:21 ` [GSoC] [PATCH v3 0/2] " Shubham Mishra
2022-03-12  6:21   ` [PATCH v3 1/2] t0001-t0028: " Shubham Mishra
2022-03-12  6:21   ` [PATCH v3 2/2] t0030-t0050: " Shubham Mishra
2022-03-12  9:05   ` [GSoC] [PATCH v3 0/2] " Johannes Sixt
2022-03-12 10:27     ` Shubham Mishra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220227122453.25278-1-shivam828787@gmail.com \
    --to=shivam828787@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).