git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [GSoC] Microproject for git
@ 2020-03-18 18:59 Harshit Jain
  2020-03-18 19:27 ` Shourya Shukla
  0 siblings, 1 reply; 4+ messages in thread
From: Harshit Jain @ 2020-03-18 18:59 UTC (permalink / raw)
  To: git

Hi,
I am Harshit Jain, a senior undergraduate student pursuing bachelors
at IIT Delhi. In the coming summers, I am really looking forward to
contribute to git as a part of the GSoC program. And for the same, I
am working on the "Use test_path_is_* functions in test scripts"
microproject. As a part of the same, I found a few test scripts where
the 'test -f' can potentially be replaced by 'test_path_is_file'
function. I changed one test script and it works fine. So, should I
just commit this change now (the change looks very trivial to me) and
if not, how to proceed from here?

Kind regards,
Harshit Jain
Senior Undergraduate, IIT Delhi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re:[GSoC] Microproject for git
  2020-03-18 18:59 [GSoC] Microproject for git Harshit Jain
@ 2020-03-18 19:27 ` Shourya Shukla
  2020-03-18 20:05   ` [GSoC] " Hariom verma
  0 siblings, 1 reply; 4+ messages in thread
From: Shourya Shukla @ 2020-03-18 19:27 UTC (permalink / raw)
  To: harshitjain1371999; +Cc: git, Shourya Shukla

Hello Harshit,

> I found a few test scripts where the 'test -f' can potentially be replaced by 'test_path_is_file'
> function.

That's nice!

> I changed one test script and it works fine. So, should I
> just commit this change now (the change looks very trivial to me) and
> if not, how to proceed from here?

Make sure to execute a 'make' in the working directory so that your changes
_actually_ have some effect. Running a changed test without 'make' is
basically running the old test all over again.

You could also maybe do some code modernizations. What I did as my microproject
might be of some help:

https://lore.kernel.org/git/20200118083326.9643-1-shouryashukla.oo@gmail.com/

Also, make sure the commit message is descriptive and does not contain any
extra whitespaces. I think you must know by now that we submit patches here
via the mailing list and not pull requests.

Regards,
Shourya Shukla

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GSoC] Microproject for git
  2020-03-18 19:27 ` Shourya Shukla
@ 2020-03-18 20:05   ` Hariom verma
  2020-03-19  8:03     ` Kaartic Sivaraam
  0 siblings, 1 reply; 4+ messages in thread
From: Hariom verma @ 2020-03-18 20:05 UTC (permalink / raw)
  To: harshitjain1371999; +Cc: git, shouryashukla.oo

Hi Harshit,

On Thu, Mar 19, 2020 at 12:58 AM Shourya Shukla
> I think you must know by now that we submit patches here
> via the mailing list and not pull requests.

I addition to what Shourya said, you can also make it easier on
yourself by using GitGitGadget, which takes out the pain of sending
patches in the required format via email, see
https://gitgitgadget.github.io/ for details.

Regards,
Hariom

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GSoC] Microproject for git
  2020-03-18 20:05   ` [GSoC] " Hariom verma
@ 2020-03-19  8:03     ` Kaartic Sivaraam
  0 siblings, 0 replies; 4+ messages in thread
From: Kaartic Sivaraam @ 2020-03-19  8:03 UTC (permalink / raw)
  To: harshitjain1371999; +Cc: Hariom verma, git, shouryashukla.oo

Hi Harshit,

On 19-03-2020 01:35, Hariom verma wrote:
> Hi Harshit,
> 
> On Thu, Mar 19, 2020 at 12:58 AM Shourya Shukla
>> I think you must know by now that we submit patches here
>> via the mailing list and not pull requests.
> 
> I addition to what Shourya said, you can also make it easier on
> yourself by using GitGitGadget, which takes out the pain of sending
> patches in the required format via email, see
> https://gitgitgadget.github.io/ for details.
> 

There's also a MyFirstContribution[1] document which could help you. 
Particularly, there's a section[2] which contains step-by-step 
information about how to send patches using GitGitGadget.

Good luck with your contribution :)

[1]: https://git-scm.com/docs/MyFirstContribution
[2]: https://git-scm.com/docs/MyFirstContribution#howto-ggg

-- 
Sivaraam

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-19  8:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 18:59 [GSoC] Microproject for git Harshit Jain
2020-03-18 19:27 ` Shourya Shukla
2020-03-18 20:05   ` [GSoC] " Hariom verma
2020-03-19  8:03     ` Kaartic Sivaraam

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).