From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: harshitjain1371999@gmail.com
Cc: git@vger.kernel.org, Shourya Shukla <shouryashukla.oo@gmail.com>
Subject: Re:[GSoC] Microproject for git
Date: Thu, 19 Mar 2020 00:57:19 +0530 [thread overview]
Message-ID: <20200318192719.1127-1-shouryashukla.oo@gmail.com> (raw)
In-Reply-To: <CACuU+s9BsWVCMXpp6KgJ-NaDuadcegZ2kVSMmuAYO9YquTK8LA@mail.gmail.com>
Hello Harshit,
> I found a few test scripts where the 'test -f' can potentially be replaced by 'test_path_is_file'
> function.
That's nice!
> I changed one test script and it works fine. So, should I
> just commit this change now (the change looks very trivial to me) and
> if not, how to proceed from here?
Make sure to execute a 'make' in the working directory so that your changes
_actually_ have some effect. Running a changed test without 'make' is
basically running the old test all over again.
You could also maybe do some code modernizations. What I did as my microproject
might be of some help:
https://lore.kernel.org/git/20200118083326.9643-1-shouryashukla.oo@gmail.com/
Also, make sure the commit message is descriptive and does not contain any
extra whitespaces. I think you must know by now that we submit patches here
via the mailing list and not pull requests.
Regards,
Shourya Shukla
next prev parent reply other threads:[~2020-03-18 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 18:59 [GSoC] Microproject for git Harshit Jain
2020-03-18 19:27 ` Shourya Shukla [this message]
2020-03-18 20:05 ` Hariom verma
2020-03-19 8:03 ` Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318192719.1127-1-shouryashukla.oo@gmail.com \
--to=shouryashukla.oo@gmail.com \
--cc=git@vger.kernel.org \
--cc=harshitjain1371999@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).