git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* should "--recurse-submodule" be "--recurse-submodules"?
@ 2018-02-14  0:30 Robert P. J. Day
  2018-02-14 19:12 ` Stefan Beller
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2018-02-14  0:30 UTC (permalink / raw)
  To: Git Mailing list


  also just noticed the following:

Documentation/RelNotes/2.13.0.txt:489: * A few commands that recently learned the "--recurse-submodule"
Documentation/RelNotes/2.12.0.txt:226: * "git push --dry-run --recurse-submodule=on-demand" wasn't
Documentation/RelNotes/2.11.1.txt:27: * "git push --dry-run --recurse-submodule=on-demand" wasn't
t/t5531-deep-submodule-push.sh:366:		git push --recurse-submodule=check origin master
t/t5572-pull-submodule.sh:45:test_expect_success 'pull --recurse-submodule setup' '

  should some of those be corrected?

rday

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: should "--recurse-submodule" be "--recurse-submodules"?
  2018-02-14  0:30 should "--recurse-submodule" be "--recurse-submodules"? Robert P. J. Day
@ 2018-02-14 19:12 ` Stefan Beller
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Beller @ 2018-02-14 19:12 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Git Mailing list

On Tue, Feb 13, 2018 at 4:30 PM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
>   also just noticed the following:
>
> Documentation/RelNotes/2.13.0.txt:489: * A few commands that recently learned the "--recurse-submodule"
> Documentation/RelNotes/2.12.0.txt:226: * "git push --dry-run --recurse-submodule=on-demand" wasn't
> Documentation/RelNotes/2.11.1.txt:27: * "git push --dry-run --recurse-submodule=on-demand" wasn't
> t/t5531-deep-submodule-push.sh:366:             git push --recurse-submodule=check origin master
> t/t5572-pull-submodule.sh:45:test_expect_success 'pull --recurse-submodule setup' '
>
>   should some of those be corrected?

I get the same list via
  git grep -- --recurse-submodule |grep -v -- --recurse-submodules
so there is no missing piece left.

As you can see, the first 3 are Documentation, and the other 2 are tests,
the actual code is always --recurse-submodules (with an s!).

Fixing the docs as well as t5572 has the impact of "just fixing typos"
(though that is specifically valuable for command line options where
exact spelling matters)

The fix in 5531 is an actual bugfix in the test suite, which
went unnoticed as the test itself did not fail.

The test did not fail because git autocompleted the command
line option silently. But that is not what we want to test there.

Stefan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14  0:30 should "--recurse-submodule" be "--recurse-submodules"? Robert P. J. Day
2018-02-14 19:12 ` Stefan Beller

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox