mailing list mirror (one of many)
 help / Atom feed
From: Stefan Beller <>
To: "Robert P. J. Day" <>
Cc: Git Mailing list <>
Subject: Re: should "--recurse-submodule" be "--recurse-submodules"?
Date: Wed, 14 Feb 2018 11:12:07 -0800
Message-ID: <> (raw)
In-Reply-To: <alpine.LFD.2.21.1802131927310.17903@localhost.localdomain>

On Tue, Feb 13, 2018 at 4:30 PM, Robert P. J. Day <> wrote:
>   also just noticed the following:
> Documentation/RelNotes/2.13.0.txt:489: * A few commands that recently learned the "--recurse-submodule"
> Documentation/RelNotes/2.12.0.txt:226: * "git push --dry-run --recurse-submodule=on-demand" wasn't
> Documentation/RelNotes/2.11.1.txt:27: * "git push --dry-run --recurse-submodule=on-demand" wasn't
> t/             git push --recurse-submodule=check origin master
> t/ 'pull --recurse-submodule setup' '
>   should some of those be corrected?

I get the same list via
  git grep -- --recurse-submodule |grep -v -- --recurse-submodules
so there is no missing piece left.

As you can see, the first 3 are Documentation, and the other 2 are tests,
the actual code is always --recurse-submodules (with an s!).

Fixing the docs as well as t5572 has the impact of "just fixing typos"
(though that is specifically valuable for command line options where
exact spelling matters)

The fix in 5531 is an actual bugfix in the test suite, which
went unnoticed as the test itself did not fail.

The test did not fail because git autocompleted the command
line option silently. But that is not what we want to test there.


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14  0:30 Robert P. J. Day
2018-02-14 19:12 ` Stefan Beller [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox