From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Cc: Daniel Stenberg <daniel@haxx.se>
Subject: Re: [PATCH] http: match headers case-insensitively when redacting
Date: Wed, 22 Sep 2021 09:32:41 +0700 [thread overview]
Message-ID: <afd7bd6b-52bf-7fd8-d13e-6dcd660c4100@gmail.com> (raw)
In-Reply-To: <YUonS1uoZlZEt+Yd@coredump.intra.peff.net>
On 22/09/21 01.41, Jeff King wrote:
> But when HTTP/2 is in use, instead we get a lower-case "authorization:"
> header, and we fail to match it. The fix is simple: we should match with
> skip_iprefix().
>
> Testing is more complicated, though. We do have a test for the redacting
> feature, but we don't hit the problem case because our test Apache setup
> does not understand HTTP/2. You can reproduce the issue by applying this
> on top of the test change in this patch:
>
> diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
> index afa91e38b0..19267c7107 100644
> --- a/t/lib-httpd/apache.conf
> +++ b/t/lib-httpd/apache.conf
> @@ -29,6 +29,9 @@ ErrorLog error.log
> LoadModule setenvif_module modules/mod_setenvif.so
> </IfModule>
>
> +LoadModule http2_module modules/mod_http2.so
> +Protocols h2c
> +
> <IfVersion < 2.4>
> LockFile accept.lock
> </IfVersion>
> @@ -64,8 +67,8 @@ LockFile accept.lock
> <IfModule !mod_access_compat.c>
> LoadModule access_compat_module modules/mod_access_compat.so
> </IfModule>
> -<IfModule !mod_mpm_prefork.c>
> - LoadModule mpm_prefork_module modules/mod_mpm_prefork.so
> +<IfModule !mod_mpm_event.c>
> + LoadModule mpm_event_module modules/mod_mpm_event.so
> </IfModule>
> <IfModule !mod_unixd.c>
> LoadModule unixd_module modules/mod_unixd.so
> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index 1c2a444ae7..ff74f0ae8a 100755
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -24,6 +24,10 @@ test_expect_success 'create http-accessible bare repository' '
> git push public main:main
> '
>
> +test_expect_success 'prefer http/2' '
> + git config --global http.version HTTP/2
> +'
> +
> setup_askpass_helper
>
> test_expect_success 'clone http repository' '
>
> but this has a few issues:
>
> - it's not necessarily portable. The http2 apache module might not be
> available on all systems. Further, the http2 module isn't compatible
> with the prefork mpm, so we have to switch to something else. But we
> don't necessarily know what's available. It would be nice if we
> could have conditional config, but IfModule only tells us if a
> module is already loaded, not whether it is available at all.
>
> This might be a non-issue. The http tests are already optional, and
> modern-enough systems may just have both of these. But...
>
> - if we do this, then we'd no longer be testing HTTP/1.1 at all. I'm
> not sure how much that matters since it's all handled by curl under
> the hood, but I'd worry that some detail leaks through. We'd
> probably want two scripts running similar tests, one with HTTP/2 and
> one with HTTP/1.1.
Maybe for httpd config we can say that if mpm_prefork isn't loaded, load
mpm_event and mod_http2.
And for testing both HTTP/2 and HTTP/1.1 did you mean sharing the same
test code (with adjustments for each protocol)?
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-09-22 2:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 18:41 [PATCH] http: match headers case-insensitively when redacting Jeff King
2021-09-21 18:47 ` Jeff King
2021-09-21 20:14 ` Carlo Arenas
2021-09-21 20:40 ` Jeff King
2021-09-21 22:00 ` Daniel Stenberg
2021-09-22 2:32 ` Jeff King
2021-09-21 19:06 ` Eric Sunshine
2021-09-21 19:14 ` Jeff King
2021-09-22 19:10 ` Junio C Hamano
2021-09-21 21:20 ` Taylor Blau
2021-09-22 2:30 ` Jeff King
2021-09-22 2:32 ` Bagas Sanjaya [this message]
2021-09-22 20:11 ` Jeff King
2021-09-23 1:22 ` Ævar Arnfjörð Bjarmason
2021-09-23 21:56 ` Jeff King
2021-09-22 19:19 ` Junio C Hamano
2021-09-22 20:09 ` Jeff King
2021-09-22 20:51 ` Junio C Hamano
2021-09-22 21:18 ` Jeff King
2021-09-22 21:42 ` Junio C Hamano
2021-09-22 22:11 ` [PATCH v2] " Jeff King
2021-09-22 22:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd7bd6b-52bf-7fd8-d13e-6dcd660c4100@gmail.com \
--to=bagasdotme@gmail.com \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).