From: Jeff King <peff@peff.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org, Daniel Stenberg <daniel@haxx.se>
Subject: Re: [PATCH] http: match headers case-insensitively when redacting
Date: Wed, 22 Sep 2021 16:11:36 -0400 [thread overview]
Message-ID: <YUuN+KguN0WetC49@coredump.intra.peff.net> (raw)
In-Reply-To: <afd7bd6b-52bf-7fd8-d13e-6dcd660c4100@gmail.com>
On Wed, Sep 22, 2021 at 09:32:41AM +0700, Bagas Sanjaya wrote:
> > but this has a few issues:
> >
> > - it's not necessarily portable. The http2 apache module might not be
> > available on all systems. Further, the http2 module isn't compatible
> > with the prefork mpm, so we have to switch to something else. But we
> > don't necessarily know what's available. It would be nice if we
> > could have conditional config, but IfModule only tells us if a
> > module is already loaded, not whether it is available at all.
> >
> > This might be a non-issue. The http tests are already optional, and
> > modern-enough systems may just have both of these. But...
> >
> > - if we do this, then we'd no longer be testing HTTP/1.1 at all. I'm
> > not sure how much that matters since it's all handled by curl under
> > the hood, but I'd worry that some detail leaks through. We'd
> > probably want two scripts running similar tests, one with HTTP/2 and
> > one with HTTP/1.1.
>
> Maybe for httpd config we can say that if mpm_prefork isn't loaded, load
> mpm_event and mod_http2.
That doesn't work. We can say "is mpm_prefork" loaded, and indeed we
already do, in order to load mpm_prefork! That's because the module may
or may not be built-in, and if not, we have to load it (or some mpm
module). See 296f0b3ea9 (t/lib-httpd/apache.conf: configure an MPM
module for apache 2.4, 2013-06-09).
But we have no way of knowing _which_ modules are available. It may just
be that "event" or "worker" (both of which support mod_http2) are
available close enough to everywhere that we can just guess.
> And for testing both HTTP/2 and HTTP/1.1 did you mean sharing the same test
> code (with adjustments for each protocol)?
Yes. I'd literally run the same battery of tests against both protocols
(see my other response to Taylor with a sketched-out example). I'm still
not sure it's entirely worth the effort, though. The underlying
transport should be pretty transparent to Git, with the exception of
things like debugging output.
-Peff
next prev parent reply other threads:[~2021-09-22 20:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 18:41 [PATCH] http: match headers case-insensitively when redacting Jeff King
2021-09-21 18:47 ` Jeff King
2021-09-21 20:14 ` Carlo Arenas
2021-09-21 20:40 ` Jeff King
2021-09-21 22:00 ` Daniel Stenberg
2021-09-22 2:32 ` Jeff King
2021-09-21 19:06 ` Eric Sunshine
2021-09-21 19:14 ` Jeff King
2021-09-22 19:10 ` Junio C Hamano
2021-09-21 21:20 ` Taylor Blau
2021-09-22 2:30 ` Jeff King
2021-09-22 2:32 ` Bagas Sanjaya
2021-09-22 20:11 ` Jeff King [this message]
2021-09-23 1:22 ` Ævar Arnfjörð Bjarmason
2021-09-23 21:56 ` Jeff King
2021-09-22 19:19 ` Junio C Hamano
2021-09-22 20:09 ` Jeff King
2021-09-22 20:51 ` Junio C Hamano
2021-09-22 21:18 ` Jeff King
2021-09-22 21:42 ` Junio C Hamano
2021-09-22 22:11 ` [PATCH v2] " Jeff King
2021-09-22 22:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUuN+KguN0WetC49@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bagasdotme@gmail.com \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).