From: Jeff King <peff@peff.net>
To: Daniel Stenberg <daniel@haxx.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http: match headers case-insensitively when redacting
Date: Tue, 21 Sep 2021 22:32:01 -0400 [thread overview]
Message-ID: <YUqVoVgt47E80HhV@coredump.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.2109212351440.26668@fvyyl>
On Wed, Sep 22, 2021 at 12:00:03AM +0200, Daniel Stenberg wrote:
> > At any rate, I wonder if it would be friendlier for curl to hand strings
> > to the debug function with the usual capitalization.
>
> Maybe that could've been a good idea if we had done it when we introduced
> HTTP/2 support. Now, I think that ship has sailed already as libcurl has
> supported HTTP/2 since late 2013 and changing anything like that now will
> just risk introducing the reverse surprise in applications. Better not rock
> that boat now methinks.
Oof, that's much older than I realized. I agree the ship has long
sailed, and we are better off leaving things as-is.
> > PS This nit aside, it is totally cool that I have been seamlessly using
> > HTTP/2 to talk to github.com without even realizing it. I wonder for
> > how long!
>
> I don't know when github.com started supporting h2, but since libcurl 7.62.0
> (released Oct 31, 2018) it has negotiated h2 by default over HTTPS.
I dug a bit. Looks like it was enabled at the load-balancing layer of
github.com around January of this year.
-Peff
next prev parent reply other threads:[~2021-09-22 2:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 18:41 [PATCH] http: match headers case-insensitively when redacting Jeff King
2021-09-21 18:47 ` Jeff King
2021-09-21 20:14 ` Carlo Arenas
2021-09-21 20:40 ` Jeff King
2021-09-21 22:00 ` Daniel Stenberg
2021-09-22 2:32 ` Jeff King [this message]
2021-09-21 19:06 ` Eric Sunshine
2021-09-21 19:14 ` Jeff King
2021-09-22 19:10 ` Junio C Hamano
2021-09-21 21:20 ` Taylor Blau
2021-09-22 2:30 ` Jeff King
2021-09-22 2:32 ` Bagas Sanjaya
2021-09-22 20:11 ` Jeff King
2021-09-23 1:22 ` Ævar Arnfjörð Bjarmason
2021-09-23 21:56 ` Jeff King
2021-09-22 19:19 ` Junio C Hamano
2021-09-22 20:09 ` Jeff King
2021-09-22 20:51 ` Junio C Hamano
2021-09-22 21:18 ` Jeff King
2021-09-22 21:42 ` Junio C Hamano
2021-09-22 22:11 ` [PATCH v2] " Jeff King
2021-09-22 22:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUqVoVgt47E80HhV@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).