From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 1/2] refs: introduce reftable backend
Date: Fri, 2 Feb 2024 11:52:10 +0100 [thread overview]
Message-ID: <ZbzJWo-DBpGZiMO4@tanuki> (raw)
In-Reply-To: <ZbyoL3r7yEVYe35B@tanuki>
[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]
On Fri, Feb 02, 2024 at 09:30:39AM +0100, Patrick Steinhardt wrote:
> On Thu, Feb 01, 2024 at 07:17:45AM -0800, Karthik Nayak wrote:
> > > + iter->err = reftable_iterator_next_ref(&iter->iter, &iter->ref);
> > > + if (iter->err)
> > > + break;
> > > +
> > > + /*
> > > + * The files backend only lists references contained in
> > > + * "refs/". We emulate the same behaviour here and thus skip
> > > + * all references that don't start with this prefix.
> > > + */
> > > + if (!starts_with(iter->ref.refname, "refs/"))
> > > + continue;
> > > +
> >
> > Since my patch series [1] to print all refs is now merged to next, maybe
> > you could add this in?
> >
> > diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
> > index 895de0b273..3f4f905292 100644
> > --- a/refs/reftable-backend.c
> > +++ b/refs/reftable-backend.c
> > @@ -348,11 +348,10 @@ static int
> > reftable_ref_iterator_advance(struct ref_iterator *ref_iterator)
> > break;
> >
> > /*
> > - * The files backend only lists references contained in
> > - * "refs/". We emulate the same behaviour here and thus skip
> > - * all references that don't start with this prefix.
> > + * Unless the `DO_FOR_EACH_INCLUDE_ALL_REFS` flag is use, we only
> > + * list references contained in "refs/" to mimic the file-backend.
> > */
> > - if (!starts_with(iter->ref.refname, "refs/"))
> > + if (!(iter->flags & DO_FOR_EACH_INCLUDE_ALL_REFS) &&
> > !starts_with(iter->ref.refname, "refs/"))
> > continue;
> >
> > if (iter->prefix &&
>
> I'm still waiting for your patch series to hit `next` before making it a
> dependency of this series, but thanks for the patch!
Oops, didn't read this carefully enough and missed that it already is in
`next`. I'll adapt accordingly in the next version, thanks!
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-02 10:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 8:05 [PATCH 0/2] refs: introduce reftable backend Patrick Steinhardt
2024-01-30 8:05 ` [PATCH 1/2] " Patrick Steinhardt
2024-02-01 15:17 ` Karthik Nayak
2024-02-02 8:30 ` Patrick Steinhardt
2024-02-02 10:52 ` Patrick Steinhardt [this message]
2024-01-30 8:05 ` [PATCH 2/2] ci: add jobs to test with the " Patrick Steinhardt
2024-01-30 22:08 ` [PATCH 0/2] refs: introduce " Junio C Hamano
2024-02-02 8:38 ` [PATCH v2 " Patrick Steinhardt
2024-02-02 8:38 ` [PATCH v2 1/2] " Patrick Steinhardt
2024-02-02 8:38 ` [PATCH v2 2/2] ci: add jobs to test with the " Patrick Steinhardt
2024-02-02 13:02 ` [PATCH v2 0/2] refs: introduce " Karthik Nayak
2024-02-03 20:41 ` Junio C Hamano
2024-02-04 6:00 ` Patrick Steinhardt
2024-02-05 6:02 ` [PATCH v3 " Patrick Steinhardt
2024-02-05 6:02 ` [PATCH v3 1/2] " Patrick Steinhardt
2024-02-05 6:02 ` [PATCH v3 2/2] ci: add jobs to test with the " Patrick Steinhardt
2024-02-05 13:10 ` [PATCH v3 0/2] refs: introduce " Karthik Nayak
2024-02-07 7:20 ` [PATCH v4 " Patrick Steinhardt
2024-02-07 7:20 ` [PATCH v4 1/2] " Patrick Steinhardt
2024-02-07 22:31 ` Jeff King
2024-02-08 5:11 ` Patrick Steinhardt
2024-02-15 5:39 ` Jeff King
2024-02-07 7:20 ` [PATCH v4 2/2] ci: add jobs to test with the " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbzJWo-DBpGZiMO4@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).