From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 0/2] refs: introduce reftable backend
Date: Tue, 30 Jan 2024 14:08:05 -0800 [thread overview]
Message-ID: <xmqqil3aa30a.fsf@gitster.g> (raw)
In-Reply-To: <cover.1706601199.git.ps@pks.im> (Patrick Steinhardt's message of "Tue, 30 Jan 2024 09:05:26 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> Patrick Steinhardt (2):
> refs: introduce reftable backend
> ci: add jobs to test with the reftable backend
I haven't checked the code in refs/reftable-backend.c at all, but
judging from the fallout to other files, it issurprisingly cleanly
done. I somehow expected that we would need more changes like
exposing the helper function to compute shared permission bits,
but I see that it was the only change needed. Everything else done
to other files are natural requirement to plug the new thing as a
new ref backend to the system. Very nicely done.
Thanks.
> .github/workflows/main.yml | 9 +
> .gitlab-ci.yml | 9 +
> Documentation/ref-storage-format.txt | 2 +
> .../technical/repository-version.txt | 5 +-
> Makefile | 1 +
> ci/lib.sh | 2 +-
> ci/run-build-and-tests.sh | 3 +
> contrib/workdir/git-new-workdir | 2 +-
> path.c | 2 +-
> path.h | 1 +
> refs.c | 1 +
> refs/refs-internal.h | 1 +
> refs/reftable-backend.c | 2286 +++++++++++++++++
> repository.h | 5 +-
> t/t0610-reftable-basics.sh | 887 +++++++
> t/t0611-reftable-httpd.sh | 26 +
> t/test-lib.sh | 2 +
> 17 files changed, 3237 insertions(+), 7 deletions(-)
> create mode 100644 refs/reftable-backend.c
> create mode 100755 t/t0610-reftable-basics.sh
> create mode 100755 t/t0611-reftable-httpd.sh
next prev parent reply other threads:[~2024-01-30 22:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 8:05 [PATCH 0/2] refs: introduce reftable backend Patrick Steinhardt
2024-01-30 8:05 ` [PATCH 1/2] " Patrick Steinhardt
2024-02-01 15:17 ` Karthik Nayak
2024-02-02 8:30 ` Patrick Steinhardt
2024-02-02 10:52 ` Patrick Steinhardt
2024-01-30 8:05 ` [PATCH 2/2] ci: add jobs to test with the " Patrick Steinhardt
2024-01-30 22:08 ` Junio C Hamano [this message]
2024-02-02 8:38 ` [PATCH v2 0/2] refs: introduce " Patrick Steinhardt
2024-02-02 8:38 ` [PATCH v2 1/2] " Patrick Steinhardt
2024-02-02 8:38 ` [PATCH v2 2/2] ci: add jobs to test with the " Patrick Steinhardt
2024-02-02 13:02 ` [PATCH v2 0/2] refs: introduce " Karthik Nayak
2024-02-03 20:41 ` Junio C Hamano
2024-02-04 6:00 ` Patrick Steinhardt
2024-02-05 6:02 ` [PATCH v3 " Patrick Steinhardt
2024-02-05 6:02 ` [PATCH v3 1/2] " Patrick Steinhardt
2024-02-05 6:02 ` [PATCH v3 2/2] ci: add jobs to test with the " Patrick Steinhardt
2024-02-05 13:10 ` [PATCH v3 0/2] refs: introduce " Karthik Nayak
2024-02-07 7:20 ` [PATCH v4 " Patrick Steinhardt
2024-02-07 7:20 ` [PATCH v4 1/2] " Patrick Steinhardt
2024-02-07 22:31 ` Jeff King
2024-02-08 5:11 ` Patrick Steinhardt
2024-02-15 5:39 ` Jeff King
2024-02-07 7:20 ` [PATCH v4 2/2] ci: add jobs to test with the " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqil3aa30a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).