* Potential Bug - GIT/GIT LFS doing dnsquery on an IP address
@ 2022-03-21 23:20 Hecker, David A
2022-03-21 23:51 ` brian m. carlson
0 siblings, 1 reply; 2+ messages in thread
From: Hecker, David A @ 2022-03-21 23:20 UTC (permalink / raw)
To: git@vger.kernel.org
I started the message below with git bugreport so I think I have all the details. (UPPERCASE to highlight; not shouting. 😊)
Thanks!
--Dave Hecker
====================================================================================================
WHAT DID YOU DO BEFORE THE BUG HAPPENED? (STEPS TO REPRODUCE YOUR ISSUE)
----------------------------------------------------------------------------------------------------
I have an older laptop running Visual Studio 2019 and Git-2.35.1.2-64-bit.exe WITH the "GIT LFS" option checked, which is working as expected: committing a change to a large file and pushing the changes DOES update the remote repository with the change, and other team members who ALREADY HAVE A FULL COPY OF THE OLDER LARGE FILE are able to pull changes and will receive the updated copy of that file.
Another team member and I got a new laptop and set up Visual Studio 2019 and Git-2.35.1.2-64-bit.exe, and then attempted to clone the repository. The clone succeeds, but checkout fails with this error:
batch response: Post https://tfs.acsgs.com/tfs/PDSI/HRS2/Learning/_git/KnowledgeConnection.git/info/lfs/objects/batch:
lookup 216.115.169.22: dnsquery: DNS name does not exist.
GIT/GIT LFS successfully resolved "tfs.acsgs.com" to the IP 216.115.169.22 for the clone, but then it seems like it’s mistakenly attempted a DNS lookup of "216.115.169.22" which fails because it's already an IP address, NOT a DNS name. (Doing "nslookup 216.115.169.22" fails in a similar/expected way: "can't find 216.115.169.22: Non-existent domain".)
IMPORTANT: I then tried cloning to a new folder on my OLDER (Windows 7) laptop, and GOT THE SAME ERROR. Therefore I SUSPECT this is NOT related to my NEWER (Windows 10) vs. OLDER (Windows 7) laptop, but instead seems to be a GIT/GIT LFS bug…and only when attempting the initial download of an “actual” file.
Another possibility is our internal TFS server perhaps has changed configuration since the first time we cloned our repository, but it seems unlikely (I can manually download a large file into my local folder, then GIT/GIT LFS will manage it properly…it seems to be only when trying to make the initial download of a full file that fails with this “lookup 216.115.169.22: dnsquery: DNS name does not exist” error).
====================================================================================================
====================================================================================================
WHAT I EXPECTED: All the files managed by LFS should be downloaded to my local folder.
WHAT HAPPENED: The "lookup 216.115.169.22" error aborts the process and I don’t get the files that are managed by LFS.
----------------------------------------------------------------------------------------------------
FYI at this point I can issue these commands in GIT BASH and get the same error:
myid@mypc MINGW64 /c/test/test (master)
$ git fetch
{successful; no message reported}
myid@mypc MINGW64 /c/test/test (master)
$ git pull
{successful; reports the following}
Already up to date.
myid@mypc MINGW64 /c/test/test (master)
$ git lfs fetch
{fails; reports the following}
fetch: Fetching reference refs/heads/master
batch response: Post https://tfs.acsgs.com/tfs/PDSI/HRS2/Learning/_git/KnowledgeConnection.git/info/lfs/objects/batch: lookup 216.115.169.22: dnsquery: DNS name does not exist.
error: failed to fetch some objects from 'https://tfs.acsgs.com/tfs/PDSI/HRS2/Learning/_git/KnowledgeConnection.git/info/lfs'
====================================================================================================
====================================================================================================
HERE'S THE LOG OF THE INITIAL CLONE:
----------------------------------------------------------------------------------------------------
Cloning into 'c:Test'...
remote:
remote: fTfs
remote: fSSSSSSSs
remote: fSSSSSSSSSS
remote: TSSf fSSSSSSSSSSSS
remote: SSSSSF fSSSSSSST SSSSS
remote: SSfSSSSSsfSSSSSSSt SSSSS
remote: SS tSSSSSSSSSs SSSSS
remote: SS fSSSSSSST SSSSS
remote: SS fSSSSSFSSSSSSf SSSSS
remote: SSSSSST FSSSSSSFt SSSSS
remote: SSSSt FSSSSSSSSSSSS
remote: FSSSSSSSSSS
remote: FSSSSSSs
remote: FSFs (TM)
remote:
remote: Microsoft (R) Visual Studio (R) Team Foundation Server
remote:
Receiving objects: 100% (358654/358654), 498.24 MiB | 8.25 MiB/s, done.
Resolving deltas: 100% (318843/318843), done.
error: unable to create file Nucleus/SharedSolution/BusinessServices/Service References/Internal.CompletionCertificateManagementServiceProxy/LearnSomething.Nucleus.BusinessServices.Internal.CompletionCertificateManagementServiceProxy.DeleteUnapprovedTemplateResponse.datasource: Filename too long
Updating files: 100% (9290/9290), done.
Downloading Extras/LSADataAdapterSolution/lib/LearnSomethingAbout.llblgenproj (77 KB)
Error downloading object: Extras/LSADataAdapterSolution/lib/LearnSomethingAbout.llblgenproj (5e4f888): Smudge error: Error downloading Extras/LSADataAdapterSolution/lib/LearnSomethingAbout.llblgenproj (5e4f888baf46329f841612572a39fd9d3a5c803b5c051fcb8548cbaeadce5333): batch response: Post https://tfs.acsgs.com/tfs/PDSI/HRS2/Learning/_git/KnowledgeConnection.git/info/lfs/objects/batch: lookup 216.115.169.22: dnsquery: DNS name does not exist.
Errors logged to C:\Test\Test\.git\lfs\logs\20220321T132305.040305.log
Use `git lfs logs last` to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: Extras/LSADataAdapterSolution/lib/LearnSomethingAbout.llblgenproj: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
====================================================================================================
====================================================================================================
HERE'S THE CONTENT OF THE C:\Test\Test\.git\lfs\logs\20220321T132305.040305.log FILE
(shows the same error, but also other details that may be useful)
----------------------------------------------------------------------------------------------------
git-lfs/3.0.2 (GitHub; windows amd64; go 1.17.2)
git version 2.35.1.windows.2
$ git-lfs.exe filter-process
Error downloading object: Extras/LSADataAdapterSolution/lib/LearnSomethingAbout.llblgenproj (5e4f888): Smudge error: Error downloading Extras/LSADataAdapterSolution/lib/LearnSomethingAbout.llblgenproj (5e4f888baf46329f841612572a39fd9d3a5c803b5c051fcb8548cbaeadce5333): batch response: Post https://tfs.acsgs.com/tfs/PDSI/HRS2/Learning/_git/KnowledgeConnection.git/info/lfs/objects/batch: lookup 216.115.169.22: dnsquery: DNS name does not exist.
Post https://tfs.acsgs.com/tfs/PDSI/HRS2/Learning/_git/KnowledgeConnection.git/info/lfs/objects/batch: lookup 216.115.169.22: dnsquery: DNS name does not exist.
batch response
github.com/git-lfs/git-lfs/v3/errors.newWrappedError
D:/a/git-lfs/git-lfs/errors/types.go:225
github.com/git-lfs/git-lfs/v3/errors.Wrap
D:/a/git-lfs/git-lfs/errors/errors.go:74
github.com/git-lfs/git-lfs/v3/tq.(*tqClient).Batch
D:/a/git-lfs/git-lfs/tq/api.go:95
github.com/git-lfs/git-lfs/v3/tq.Batch
D:/a/git-lfs/git-lfs/tq/api.go:43
github.com/git-lfs/git-lfs/v3/tq.(*TransferQueue).enqueueAndCollectRetriesFor
D:/a/git-lfs/git-lfs/tq/transfer_queue.go:558
github.com/git-lfs/git-lfs/v3/tq.(*TransferQueue).collectBatches.func1
D:/a/git-lfs/git-lfs/tq/transfer_queue.go:452
runtime.goexit
go/src/runtime/asm_amd64.s:1581
Error downloading Extras/LSADataAdapterSolution/lib/LearnSomethingAbout.llblgenproj (5e4f888baf46329f841612572a39fd9d3a5c803b5c051fcb8548cbaeadce5333)
github.com/git-lfs/git-lfs/v3/errors.newWrappedError
D:/a/git-lfs/git-lfs/errors/types.go:225
github.com/git-lfs/git-lfs/v3/errors.Wrapf
D:/a/git-lfs/git-lfs/errors/errors.go:85
github.com/git-lfs/git-lfs/v3/lfs.(*GitFilter).downloadFile
D:/a/git-lfs/git-lfs/lfs/gitfilter_smudge.go:119
github.com/git-lfs/git-lfs/v3/lfs.(*GitFilter).Smudge
D:/a/git-lfs/git-lfs/lfs/gitfilter_smudge.go:78
github.com/git-lfs/git-lfs/v3/commands.smudge
D:/a/git-lfs/git-lfs/commands/command_smudge.go:127
github.com/git-lfs/git-lfs/v3/commands.filterCommand
D:/a/git-lfs/git-lfs/commands/command_filter_process.go:122
github.com/spf13/cobra.(*Command).execute
mailto:go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:766
github.com/spf13/cobra.(*Command).ExecuteC
mailto:go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:852
github.com/spf13/cobra.(*Command).Execute
mailto:go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:800
github.com/git-lfs/git-lfs/v3/commands.Run
D:/a/git-lfs/git-lfs/commands/run.go:105
main.main
D:/a/git-lfs/git-lfs/git-lfs.go:33
runtime.main
go/src/runtime/proc.go:255
runtime.goexit
go/src/runtime/asm_amd64.s:1581
Smudge error
github.com/git-lfs/git-lfs/v3/errors.newWrappedError
D:/a/git-lfs/git-lfs/errors/types.go:225
github.com/git-lfs/git-lfs/v3/errors.NewSmudgeError
D:/a/git-lfs/git-lfs/errors/types.go:311
github.com/git-lfs/git-lfs/v3/lfs.(*GitFilter).Smudge
D:/a/git-lfs/git-lfs/lfs/gitfilter_smudge.go:87
github.com/git-lfs/git-lfs/v3/commands.smudge
D:/a/git-lfs/git-lfs/commands/command_smudge.go:127
github.com/git-lfs/git-lfs/v3/commands.filterCommand
D:/a/git-lfs/git-lfs/commands/command_filter_process.go:122
github.com/spf13/cobra.(*Command).execute
mailto:go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:766
github.com/spf13/cobra.(*Command).ExecuteC
mailto:go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:852
github.com/spf13/cobra.(*Command).Execute
mailto:go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:800
github.com/git-lfs/git-lfs/v3/commands.Run
D:/a/git-lfs/git-lfs/commands/run.go:105
main.main
D:/a/git-lfs/git-lfs/git-lfs.go:33
runtime.main
go/src/runtime/proc.go:255
runtime.goexit
go/src/runtime/asm_amd64.s:1581
Current time in UTC:
2022-03-21 17:23:05
ENV:
LocalWorkingDir=C:\Test\Test
LocalGitDir=C:\Test\Test\.git
LocalGitStorageDir=C:\Test\Test\.git
LocalMediaDir=C:\Test\Test\.git\lfs\objects
LocalReferenceDirs=
TempDir=C:\Test\Test\.git\lfs\tmp
ConcurrentTransfers=8
TusTransfers=false
BasicTransfersOnly=false
SkipDownloadErrors=false
FetchRecentAlways=false
FetchRecentRefsDays=7
FetchRecentCommitsDays=0
FetchRecentRefsIncludeRemotes=true
PruneOffsetDays=3
PruneVerifyRemoteAlways=false
PruneRemoteName=origin
LfsStorageDir=C:\Test\Test\.git\lfs
AccessDownload=none
AccessUpload=none
DownloadTransfers=basic,lfs-standalone-file,ssh
UploadTransfers=basic,lfs-standalone-file,ssh
GIT_DIR=C:/Test/Test/.git
GIT_EXEC_PATH=C:/Program Files/Git/mingw64/libexec/git-core
GIT_LFS_PATH=C:\Program Files\Git LFS
Client IP addresses:
fd6f:ceb3:d044:1:fc6e:cfb4:5b12:726 fd6f:ceb3:d044:1:d5a8:53d3:eb3e:d44d fe80::fc6e:cfb4:5b12:726 10.0.0.25
====================================================================================================
====================================================================================================
HERE'S THE DETAIL FROM "git bugreport":
----------------------------------------------------------------------------------------------------
[System Info]
git version:
git version 2.35.1.windows.2
cpu: x86_64
built from commit: 5437f0fd368c7faf1a0b5e1fef048232c1f2a3e6
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon
uname: Windows 10.0 19043
compiler info: gnuc: 11.2
libc info: no libc information available
$SHELL (typically, interactive shell): C:\Program Files\Git\usr\bin\bash.exe
[Enabled Hooks]
post-checkout
post-commit
post-merge
pre-push
====================================================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Potential Bug - GIT/GIT LFS doing dnsquery on an IP address
2022-03-21 23:20 Potential Bug - GIT/GIT LFS doing dnsquery on an IP address Hecker, David A
@ 2022-03-21 23:51 ` brian m. carlson
0 siblings, 0 replies; 2+ messages in thread
From: brian m. carlson @ 2022-03-21 23:51 UTC (permalink / raw)
To: Hecker, David A; +Cc: git@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 3102 bytes --]
Hey,
On 2022-03-21 at 23:20:25, Hecker, David A wrote:
> I started the message below with git bugreport so I think I have all the details. (UPPERCASE to highlight; not shouting. 😊)
>
> Thanks!
> --Dave Hecker
>
>
> ====================================================================================================
> WHAT DID YOU DO BEFORE THE BUG HAPPENED? (STEPS TO REPRODUCE YOUR ISSUE)
> ----------------------------------------------------------------------------------------------------
> I have an older laptop running Visual Studio 2019 and Git-2.35.1.2-64-bit.exe WITH the "GIT LFS" option checked, which is working as expected: committing a change to a large file and pushing the changes DOES update the remote repository with the change, and other team members who ALREADY HAVE A FULL COPY OF THE OLDER LARGE FILE are able to pull changes and will receive the updated copy of that file.
>
> Another team member and I got a new laptop and set up Visual Studio 2019 and Git-2.35.1.2-64-bit.exe, and then attempted to clone the repository. The clone succeeds, but checkout fails with this error:
>
> batch response: Post https://tfs.acsgs.com/tfs/PDSI/HRS2/Learning/_git/KnowledgeConnection.git/info/lfs/objects/batch:
> lookup 216.115.169.22: dnsquery: DNS name does not exist.
>
> GIT/GIT LFS successfully resolved "tfs.acsgs.com" to the IP 216.115.169.22 for the clone, but then it seems like it’s mistakenly attempted a DNS lookup of "216.115.169.22" which fails because it's already an IP address, NOT a DNS name. (Doing "nslookup 216.115.169.22" fails in a similar/expected way: "can't find 216.115.169.22: Non-existent domain".)
>
> IMPORTANT: I then tried cloning to a new folder on my OLDER (Windows 7) laptop, and GOT THE SAME ERROR. Therefore I SUSPECT this is NOT related to my NEWER (Windows 10) vs. OLDER (Windows 7) laptop, but instead seems to be a GIT/GIT LFS bug…and only when attempting the initial download of an “actual” file.
>
> Another possibility is our internal TFS server perhaps has changed configuration since the first time we cloned our repository, but it seems unlikely (I can manually download a large file into my local folder, then GIT/GIT LFS will manage it properly…it seems to be only when trying to make the initial download of a full file that fails with this “lookup 216.115.169.22: dnsquery: DNS name does not exist” error).
> ====================================================================================================
This looks like a Git LFS issue, and Git LFS is managed independently
from this project. Could you please open an issue on the Git LFS issue
tracker[0] instead, including all of this information, filling out the
issue template, and including the output when using GIT_TRACE=1
GIT_TRANSFER_TRACE=1 GIT_CURL_VERBOSE=1 (stripping out any
authentication headers)?
That would allow one of us who work on Git LFS to look at this in more
detail.
Thanks.
[0] https://github.com/git-lfs/git-lfs
--
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-21 23:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-21 23:20 Potential Bug - GIT/GIT LFS doing dnsquery on an IP address Hecker, David A
2022-03-21 23:51 ` brian m. carlson
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).