From: Josh Steadmon <steadmon@google.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH] l10n: README: call more attention to plural strings
Date: Tue, 21 Dec 2021 11:01:09 -0800 [thread overview]
Message-ID: <YcIkdXcLgzUk3+Jc@google.com> (raw)
In-Reply-To: <CANYiYbF31o-sQYU-OjJk=pQR5RHM0k7jqmEhiKGLeO3Suu1khQ@mail.gmail.com>
On 2021.12.16 09:10, Jiang Xin wrote:
> On Tue, Dec 14, 2021 at 6:02 AM Josh Steadmon <steadmon@google.com> wrote:
> >
> > On 2021.12.13 13:56, Junio C Hamano wrote:
> > > Josh Steadmon <steadmon@google.com> writes:
> > >
> > > > In po/README.md, we point core developers to gettext's "Preparing
> > > > Strings" documentation for advice on marking strings for translation.
> > > > However, this doc doesn't really discuss the issues around plural form
> > > > translation, which can make it seem that nothing special needs to be
> > > > done in this case.
> > > >
> > > > Add a specific callout here about marking plural-form strings so that
> > > > the advice later on in the README is not overlooked.
> > > >
> > > > Signed-off-by: Josh Steadmon <steadmon@google.com>
> > > > ---
> > > > po/README.md | 5 ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/po/README.md b/po/README.md
> > > > index dcd8436c25..fd1e024dd3 100644
> > > > --- a/po/README.md
> > > > +++ b/po/README.md
> > > > @@ -219,7 +219,10 @@ General advice:
> > > > they're part of Git's API.
> > > >
> > > > - Adjust the strings so that they're easy to translate. Most of the
> > > > - advice in `info '(gettext)Preparing Strings'` applies here.
> > > > + advice in `info '(gettext)Preparing Strings'` applies here. Strings
> > > > + referencing numbers of items may need to be split into singular and
> > > > + plural forms; see the Q\_() wrapper in the C sub-section below for an
> > > > + example.
>
> Wouldn't it be better if we add a new rule ("Strings ... an example.")
> after this one?
Fixed in V2, thanks!
next prev parent reply other threads:[~2021-12-21 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 19:56 [PATCH] l10n: README: call more attention to plural strings Josh Steadmon
2021-12-13 21:56 ` Junio C Hamano
2021-12-13 22:02 ` Josh Steadmon
2021-12-13 22:18 ` Junio C Hamano
2021-12-16 1:10 ` Jiang Xin
2021-12-21 19:01 ` Josh Steadmon [this message]
2021-12-21 19:00 ` [PATCH v2] " Josh Steadmon
2021-12-21 20:54 ` Junio C Hamano
2021-12-22 1:46 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcIkdXcLgzUk3+Jc@google.com \
--to=steadmon@google.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).