From: Jeff King <email@example.com> To: Felipe Contreras <firstname.lastname@example.org> Cc: email@example.com, "Martin Ågren" <firstname.lastname@example.org>, "brian m . carlson" <email@example.com>, "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org> Subject: Re: [PATCH 01/11] doc: allow the user to provide ASCIIDOC_EXTRA Date: Mon, 17 May 2021 04:57:49 -0400 [thread overview] Message-ID: <YKIwDTQI3sBXu+7W@coredump.intra.peff.net> (raw) In-Reply-To: <email@example.com> On Sat, May 15, 2021 at 07:13:48AM -0500, Felipe Contreras wrote: > Jeff King wrote: > > On Sat, May 15, 2021 at 05:32:08AM -0400, Jeff King wrote: > > > > > On Fri, May 14, 2021 at 07:14:25AM -0500, Felipe Contreras wrote: > > > > > > > Without `override` all additions will be ignored by make. > > > > > > That's true of all of our Makefile variables. Is there a particular > > > reason to give this one special treatment? > > > > To go into further detail: usually we distinguish variables we use > > internally from user-facing ones, and include the latter in the former. > > I see a later patch wants to start passing ASCIIDOC_EXTRA on the > > command-line, and we'd use two variables for that. > > Well, it's not exactly user-facing; it's only needed for doc-diff. It's meant for the caller of "make". Your proposed use is within doc-diff, but any user running "make ASCIIDOC_EXTRA=foo" would see the different behavior. > Would TEST_ASCIIDOC_EXTRA make sense? I'd probably call it ASCIIDOC_FLAGS (like we have CFLAGS and LDFLAGS that are meant for users to inform us of extra flags they'd like passed). Of course that may not solve your problem in a sense; if you want doc-diff to override it, then that might conflict with a theoretical ASCIIDOC_FLAGS somebody set in their config.mak (but we really are in the realm of hypothetical here). -Peff
next prev parent reply other threads:[~2021-05-17 8:57 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-14 12:14 [PATCH 00/11] doc: asciidoctor: direct man page creation and fixes Felipe Contreras 2021-05-14 12:14 ` [PATCH 01/11] doc: allow the user to provide ASCIIDOC_EXTRA Felipe Contreras 2021-05-15 9:32 ` Jeff King 2021-05-15 9:39 ` Jeff King 2021-05-15 12:13 ` Felipe Contreras 2021-05-17 8:57 ` Jeff King [this message] 2021-05-17 10:53 ` Felipe Contreras 2021-05-17 11:39 ` Jeff King 2021-05-17 16:50 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 02/11] doc: doc-diff: allow more than one flag Felipe Contreras 2021-05-15 9:37 ` Jeff King 2021-05-15 12:11 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 03/11] doc: doc-diff: set docdate manually Felipe Contreras 2021-05-14 15:43 ` Martin Ågren 2021-05-14 20:33 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 04/11] doc: use asciidoctor to build man pages directly Felipe Contreras 2021-05-14 15:38 ` Martin Ågren 2021-05-14 20:26 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 05/11] doc: asciidoctor: add linkgit macros in man pages Felipe Contreras 2021-05-14 12:14 ` [PATCH 06/11] doc: join mansource and manversion Felipe Contreras 2021-05-14 12:14 ` [PATCH 07/11] doc: add man pages workaround for asciidoctor Felipe Contreras 2021-05-14 12:14 ` [PATCH 08/11] doc: asciidoctor: add hack for xrefs Felipe Contreras 2021-05-14 12:14 ` [PATCH 09/11] doc: asciidoctor: add hack to improve links Felipe Contreras 2021-05-14 12:14 ` [PATCH 10/11] doc: asciidoctor: add support for baseurl Felipe Contreras 2021-05-14 12:14 ` [PATCH 11/11] doc: asciidoctor: cleanup man page hack Felipe Contreras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YKIwDTQI3sBXu+7W@coredump.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 01/11] doc: allow the user to provide ASCIIDOC_EXTRA' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).