From: Jeff King <peff@peff.net> To: Felipe Contreras <felipe.contreras@gmail.com> Cc: git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>, "brian m . carlson" <sandals@crustytoothpaste.net>, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> Subject: Re: [PATCH 02/11] doc: doc-diff: allow more than one flag Date: Sat, 15 May 2021 05:37:48 -0400 [thread overview] Message-ID: <YJ+WbMx+HTjbV2ZP@coredump.intra.peff.net> (raw) In-Reply-To: <20210514121435.504423-3-felipe.contreras@gmail.com> On Fri, May 14, 2021 at 07:14:26AM -0500, Felipe Contreras wrote: > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > --- > Documentation/doc-diff | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/doc-diff b/Documentation/doc-diff > index 1694300e50..ecd88b0524 100755 > --- a/Documentation/doc-diff > +++ b/Documentation/doc-diff > @@ -146,7 +146,7 @@ render_tree () { > # through. > oid=$1 && > dname=$2 && > - makemanflags=$3 && > + makemanflags="$3" && This line does nothing; the shell won't split whitespace here either way. > @@ -181,6 +181,6 @@ render_tree () { > fi > } > > -render_tree $from_oid $from_dir $from_makemanflags && > -render_tree $to_oid $to_dir $to_makemanflags && > +render_tree $from_oid $from_dir "$from_makemanflags" && > +render_tree $to_oid $to_dir "$to_makemanflags" && This part is necessary (and sufficient). It would be nice to mention in the commit message why the use of $makemanflags in render_tree must remain unquoted (as I did in mine when I made the same change). -Peff
next prev parent reply other threads:[~2021-05-15 9:37 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-14 12:14 [PATCH 00/11] doc: asciidoctor: direct man page creation and fixes Felipe Contreras 2021-05-14 12:14 ` [PATCH 01/11] doc: allow the user to provide ASCIIDOC_EXTRA Felipe Contreras 2021-05-15 9:32 ` Jeff King 2021-05-15 9:39 ` Jeff King 2021-05-15 12:13 ` Felipe Contreras 2021-05-17 8:57 ` Jeff King 2021-05-17 10:53 ` Felipe Contreras 2021-05-17 11:39 ` Jeff King 2021-05-17 16:50 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 02/11] doc: doc-diff: allow more than one flag Felipe Contreras 2021-05-15 9:37 ` Jeff King [this message] 2021-05-15 12:11 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 03/11] doc: doc-diff: set docdate manually Felipe Contreras 2021-05-14 15:43 ` Martin Ågren 2021-05-14 20:33 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 04/11] doc: use asciidoctor to build man pages directly Felipe Contreras 2021-05-14 15:38 ` Martin Ågren 2021-05-14 20:26 ` Felipe Contreras 2021-05-14 12:14 ` [PATCH 05/11] doc: asciidoctor: add linkgit macros in man pages Felipe Contreras 2021-05-14 12:14 ` [PATCH 06/11] doc: join mansource and manversion Felipe Contreras 2021-05-14 12:14 ` [PATCH 07/11] doc: add man pages workaround for asciidoctor Felipe Contreras 2021-05-14 12:14 ` [PATCH 08/11] doc: asciidoctor: add hack for xrefs Felipe Contreras 2021-05-14 12:14 ` [PATCH 09/11] doc: asciidoctor: add hack to improve links Felipe Contreras 2021-05-14 12:14 ` [PATCH 10/11] doc: asciidoctor: add support for baseurl Felipe Contreras 2021-05-14 12:14 ` [PATCH 11/11] doc: asciidoctor: cleanup man page hack Felipe Contreras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJ+WbMx+HTjbV2ZP@coredump.intra.peff.net \ --to=peff@peff.net \ --cc=avarab@gmail.com \ --cc=felipe.contreras@gmail.com \ --cc=git@vger.kernel.org \ --cc=martin.agren@gmail.com \ --cc=sandals@crustytoothpaste.net \ --subject='Re: [PATCH 02/11] doc: doc-diff: allow more than one flag' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).