From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Sean <seanlkml@sympatico.ca>, git@vger.kernel.org
Subject: Re: [PATCH] Colourise git-branch output
Date: Mon, 11 Dec 2006 21:41:57 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612112135360.6452@woody.osdl.org> (raw)
In-Reply-To: <7vejr5zoqe.fsf@assigned-by-dhcp.cox.net>
On Mon, 11 Dec 2006, Junio C Hamano wrote:
>
> [color]
> diff = auto
> branch = auto
> # it begs "* = auto" entry perhaps...
> [color.diff]
> old = red
> new = green
> [color.branch]
> remote = purple
I wish you'd learn to use the proper syntax ;)
It would be
[color "diff"]
old = red
new = green
and what's nice about it is that you can also do
[color "diff"]
auto
old = red
new = green
and the config file rules for booleans are such that a config variable
without the "= val" part parses the same as "= true", so you can now do
git repo-config --bool color.diff.auto
and it will say "true".
Now, I just think that would be a nice syntax.
Of course, for legacy reasons, and for people who rather than keeping the
_color_ information together want to keep the _diff_ information together,
we can/probably-should support both color.diff.* and diff.color.* formats.
next prev parent reply other threads:[~2006-12-12 5:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 22:10 [PATCH] Colourise git-branch output Andy Parkins
2006-12-11 22:47 ` Junio C Hamano
2006-12-12 0:38 ` Sean
2006-12-12 1:11 ` Junio C Hamano
2006-12-12 1:24 ` Sean
2006-12-12 3:39 ` Linus Torvalds
2006-12-12 5:07 ` Junio C Hamano
2006-12-12 5:41 ` Linus Torvalds [this message]
2006-12-12 7:58 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2006-12-12 6:41 Andy Parkins
2006-12-12 8:46 ` Johannes Sixt
2006-12-12 10:10 ` Junio C Hamano
2006-12-12 11:03 ` Andy Parkins
2006-12-12 18:43 ` Junio C Hamano
2006-12-12 18:43 ` Junio C Hamano
2006-11-03 10:52 [PATCH] Add support to git-branch to show local and remote branches Andy Parkins
2006-11-03 12:06 ` [PATCH] Colourise git-branch output Andy Parkins
2006-11-03 19:25 ` Junio C Hamano
2006-11-03 23:05 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612112135360.6452@woody.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=seanlkml@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).