From: Junio C Hamano <junkio@cox.net>
To: Sean <seanlkml@sympatico.ca>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Colourise git-branch output
Date: Mon, 11 Dec 2006 17:11:24 -0800 [thread overview]
Message-ID: <7v7iwx2a0z.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <BAYC1-PASMTP114CF00792AB16B95C1597AED70@CEZ.ICE> (seanlkml@sympatico.ca's message of "Mon, 11 Dec 2006 19:38:57 -0500")
Sean <seanlkml@sympatico.ca> writes:
> On Mon, 11 Dec 2006 22:10:08 +0000
> Andy Parkins <andyparkins@gmail.com> wrote:
>
>> +int git_branch_config(const char *var, const char *value)
>> +{
>> + if (!strcmp(var, "branch.color")) {
>> + branch_use_color = git_config_colorbool(var, value);
>> + return 0;
>> + }
>> + return git_default_config(var, value);
>> +}
>
> As Junio already highlighted, the "branch.*" namespace is for actual
> branch names. This config option should go into "color.branch" or some
> other spot.
I didn't. And "branch.color = auto" is actually fine.
The problematic case is "branch.color.remote = purple".
next prev parent reply other threads:[~2006-12-12 1:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 22:10 [PATCH] Colourise git-branch output Andy Parkins
2006-12-11 22:47 ` Junio C Hamano
2006-12-12 0:38 ` Sean
2006-12-12 1:11 ` Junio C Hamano [this message]
2006-12-12 1:24 ` Sean
2006-12-12 3:39 ` Linus Torvalds
2006-12-12 5:07 ` Junio C Hamano
2006-12-12 5:41 ` Linus Torvalds
2006-12-12 7:58 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2006-12-12 6:41 Andy Parkins
2006-12-12 8:46 ` Johannes Sixt
2006-12-12 10:10 ` Junio C Hamano
2006-12-12 11:03 ` Andy Parkins
2006-12-12 18:43 ` Junio C Hamano
2006-12-12 18:43 ` Junio C Hamano
2006-11-03 10:52 [PATCH] Add support to git-branch to show local and remote branches Andy Parkins
2006-11-03 12:06 ` [PATCH] Colourise git-branch output Andy Parkins
2006-11-03 19:25 ` Junio C Hamano
2006-11-03 23:05 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7iwx2a0z.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=seanlkml@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).