From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Colourise git-branch output
Date: Tue, 12 Dec 2006 10:43:41 -0800 [thread overview]
Message-ID: <7vpsapuf8i.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200612120641.52556.andyparkins@gmail.com
Andy Parkins <andyparkins@gmail.com> writes:
> The colour parameter is "color.branch" rather than "branch.color" to
> avoid clashing with the default namespace for default branch merge
> definitions.
Very nice.
> c = ' ';
> if (ref_list.list[i].kind == REF_LOCAL_BRANCH &&
> - !strcmp(ref_list.list[i].name, head))
> + !strcmp(ref_list.list[i].name, head)) {
> c = '*';
> + color = COLOR_BRANCH_CURRENT;
> + }
>
> if (verbose) {
> - printf("%c %-*s", c, ref_list.maxwidth,
> - ref_list.list[i].name);
> + printf("%c %s%-*s%s", c,
> + branch_get_color(color),
> + ref_list.maxwidth,
> + ref_list.list[i].name,
> + branch_get_color(COLOR_BRANCH_RESET));
> print_ref_info(ref_list.list[i].sha1, abbrev);
> }
> else
> - printf("%c %s\n", c, ref_list.list[i].name);
> + printf("%c %s%s%s\n", c,
> + branch_get_color(color),
> + ref_list.list[i].name,
> + branch_get_color(COLOR_BRANCH_RESET));
> }
Now this makes me wonder if under output coloring we would still
want the two-space indent and '*' prefix.
next prev parent reply other threads:[~2006-12-12 18:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 6:41 [PATCH] Colourise git-branch output Andy Parkins
2006-12-12 8:46 ` Johannes Sixt
2006-12-12 10:10 ` Junio C Hamano
2006-12-12 11:03 ` Andy Parkins
2006-12-12 18:43 ` Junio C Hamano
2006-12-12 18:43 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-11 22:10 Andy Parkins
2006-12-11 22:47 ` Junio C Hamano
2006-12-12 0:38 ` Sean
2006-12-12 1:11 ` Junio C Hamano
2006-12-12 1:24 ` Sean
2006-12-12 3:39 ` Linus Torvalds
2006-12-12 5:07 ` Junio C Hamano
2006-12-12 5:41 ` Linus Torvalds
2006-12-12 7:58 ` Junio C Hamano
2006-11-03 10:52 [PATCH] Add support to git-branch to show local and remote branches Andy Parkins
2006-11-03 12:06 ` [PATCH] Colourise git-branch output Andy Parkins
2006-11-03 19:25 ` Junio C Hamano
2006-11-03 23:05 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpsapuf8i.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).