From: Linus Torvalds <torvalds@osdl.org>
To: Petr Baudis <pasky@suse.cz>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [Cogito] Various bugs
Date: Tue, 7 Feb 2006 08:56:38 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0602070854380.3854@g5.osdl.org> (raw)
In-Reply-To: <20060207164946.GN31278@pasky.or.cz>
On Tue, 7 Feb 2006, Petr Baudis wrote:
>
> > Yes. That said, we should probably disallow that in git-commit-tree (and
> > let the user fix it up some way).
>
> What way? Sometimes you just receive mails from people who have only
> email addy in the from line, or you can be importing from some other VCS
> where the mapping does not exist and the importers may not deem it
> necessary to have it in GIT. Sure, it may be kernel policy to disallow
> this, but I wouldn't enforce this for all projects in GIT.
Umm. Having an empty name is _wrong_. It makes things like the shortlogs
break.
Yes, it has happened in the kernel a few times, but those were bugs, and
I'd have been very happy if git-write-tree had just aborted on me.
If you don't have any better name than the email/user-name, just use that
(but at least for the kernel, I'd much prefer a round of "google" first to
see if something better is available). An _empty_ name is never
acceptable.
Linus
next prev parent reply other threads:[~2006-02-07 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 4:13 [Cogito] Various bugs Jonas Fonseca
2006-02-07 0:36 ` Petr Baudis
2006-02-07 2:03 ` Junio C Hamano
2006-02-07 2:10 ` Petr Baudis
2006-02-07 3:03 ` Junio C Hamano
2006-02-07 15:53 ` Linus Torvalds
2006-02-07 16:49 ` Petr Baudis
2006-02-07 16:56 ` Linus Torvalds [this message]
2006-02-07 20:49 ` Junio C Hamano
2006-02-07 13:55 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0602070854380.3854@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).