From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [Cogito] Various bugs
Date: Tue, 07 Feb 2006 12:49:34 -0800 [thread overview]
Message-ID: <7v8xsmvqqp.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0602070751410.3854@g5.osdl.org> (Linus Torvalds's message of "Tue, 7 Feb 2006 07:53:57 -0800 (PST)")
Linus Torvalds <torvalds@osdl.org> writes:
> An empty GIT_AUTHOR_NAME should _not_ mean that we use the default name
> (which is usually the committer), because rather than meaning "default",
> it most likely means "buggy import script".
>
> I'd rather have an email import of mine say that it cannot commit, than
> have it put "Linus Torvalds" in the author line (and some random email).
I am inclined to agree. Something like this?
This would also make 'git-var GIT_COMMITTER_IDENT' to barf,
which I think is a good thing.
---
diff --git a/ident.c b/ident.c
index 0461b8b..23b8cfc 100644
--- a/ident.c
+++ b/ident.c
@@ -167,6 +167,11 @@ static const char *get_ident(const char
name = git_default_name;
if (!email)
email = git_default_email;
+
+ if (!*name || !*email)
+ die("empty ident %s <%s> not allowed",
+ name, email);
+
strcpy(date, git_default_date);
if (date_str)
parse_date(date_str, date, sizeof(date));
next prev parent reply other threads:[~2006-02-07 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 4:13 [Cogito] Various bugs Jonas Fonseca
2006-02-07 0:36 ` Petr Baudis
2006-02-07 2:03 ` Junio C Hamano
2006-02-07 2:10 ` Petr Baudis
2006-02-07 3:03 ` Junio C Hamano
2006-02-07 15:53 ` Linus Torvalds
2006-02-07 16:49 ` Petr Baudis
2006-02-07 16:56 ` Linus Torvalds
2006-02-07 20:49 ` Junio C Hamano [this message]
2006-02-07 13:55 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8xsmvqqp.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).