From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [Cogito] Various bugs
Date: Mon, 06 Feb 2006 19:03:00 -0800 [thread overview]
Message-ID: <7v8xsn50rf.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060207021006.GM31278@pasky.or.cz> (Petr Baudis's message of "Tue, 7 Feb 2006 03:10:06 +0100")
Petr Baudis <pasky@suse.cz> writes:
>> > I'm puzzled. GIT should handle this fine.
>> >
>> > export GIT_AUTHOR_NAME=''
>> > git-commit-tree $(cg-object-id -t)
>> >
>> > works as expected, but for some reason escaping me it does not work
>> > inside of cg-commit. Insights welcomed.
>> ...
> Thanks, I've updated the cg-commit version. Note that the empty
> GIT_AUTHOR_NAME problem seems to exist in git-commit as well.
It depends on what you expect, but it meets _my_ expectation:
$ GIT_AUTHOR_NAME='' git-commit-tree $(git-write-tree) </dev/null
Committing initial tree a2b59c3848164a2c9c3c75fbaadccaed9485da92
ef90563fa278735af367e7606ea7eb2559121ca7
$ git-cat-file commit ef90563fa278735af367e7606ea7eb2559121ca7
tree a2b59c3848164a2c9c3c75fbaadccaed9485da92
author <junkio@cox.net> 1139281078 -0800
committer Junio C Hamano <junkio@cox.net> 1139281078 -0800
That is, the user said GIT_AUTHOR_NAME is empty, so he gets a
commit with an empty author name.
get_ident() in ident.c does this. getenv("GIT_AUTHOR_NAME") and
friends are passed to it, and git_default_* are takenfrom gecos.
It might match some peoples' expectation (but not mine) if we
did this instead.
diff --git a/ident.c b/ident.c
index 0461b8b..7ec7516 100644
--- a/ident.c
+++ b/ident.c
@@ -163,9 +163,9 @@ static const char *get_ident(const char
char date[50];
int i;
- if (!name)
+ if (!name || !*name)
name = git_default_name;
- if (!email)
+ if (!email || !*email)
email = git_default_email;
strcpy(date, git_default_date);
if (date_str)
next prev parent reply other threads:[~2006-02-07 3:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 4:13 [Cogito] Various bugs Jonas Fonseca
2006-02-07 0:36 ` Petr Baudis
2006-02-07 2:03 ` Junio C Hamano
2006-02-07 2:10 ` Petr Baudis
2006-02-07 3:03 ` Junio C Hamano [this message]
2006-02-07 15:53 ` Linus Torvalds
2006-02-07 16:49 ` Petr Baudis
2006-02-07 16:56 ` Linus Torvalds
2006-02-07 20:49 ` Junio C Hamano
2006-02-07 13:55 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8xsn50rf.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).