* [PATCH] t5000: modernise archive and :(glob) test
@ 2023-02-04 20:41 Kostya Farber
2023-02-05 18:10 ` Eric Sunshine
0 siblings, 1 reply; 2+ messages in thread
From: Kostya Farber @ 2023-02-04 20:41 UTC (permalink / raw)
To: git; +Cc: Kostya Farber
To match present day coding guiding codelines let's:
- use <<-EOF, so we can indent all lines to the
the same level for this test
- use <<\EOF to notify the reader that no interpolation
is exepected in the body
Signed-off-by: Kostya Farber <kostya.farber@gmail.com>
---
t/t5000-tar-tree.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index d473048138..eb3214bc17 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -402,11 +402,11 @@ test_expect_success GZIP 'extract tgz file (external gzip)' '
test_expect_success 'archive and :(glob)' '
git archive -v HEAD -- ":(glob)**/sh" >/dev/null 2>actual &&
- cat >expect <<EOF &&
-a/
-a/bin/
-a/bin/sh
-EOF
+ cat >expect <<-\EOF &&
+ a/
+ a/bin/
+ a/bin/sh
+ EOF
test_cmp expect actual
'
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t5000: modernise archive and :(glob) test
2023-02-04 20:41 [PATCH] t5000: modernise archive and :(glob) test Kostya Farber
@ 2023-02-05 18:10 ` Eric Sunshine
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sunshine @ 2023-02-05 18:10 UTC (permalink / raw)
To: Kostya Farber; +Cc: git
On Sat, Feb 4, 2023 at 3:54 PM Kostya Farber <kostya.farber@gmail.com> wrote:
> To match present day coding guiding codelines let's:
We can probably just say "coding guidelines" rather than "coding
guiding codelines".
> - use <<-EOF, so we can indent all lines to the
> the same level for this test
>
> - use <<\EOF to notify the reader that no interpolation
> is exepected in the body
s/exepected/expected/
> Signed-off-by: Kostya Farber <kostya.farber@gmail.com>
> ---
For other reviewers who may not have been following along, this is a
suggested replacement[1] to a rejected (by me[2]) GSoC
microproject[3].
> diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
> @@ -402,11 +402,11 @@ test_expect_success GZIP 'extract tgz file (external gzip)' '
> test_expect_success 'archive and :(glob)' '
> git archive -v HEAD -- ":(glob)**/sh" >/dev/null 2>actual &&
> - cat >expect <<EOF &&
> -a/
> -a/bin/
> -a/bin/sh
> -EOF
> + cat >expect <<-\EOF &&
> + a/
> + a/bin/
> + a/bin/sh
> + EOF
> test_cmp expect actual
> '
Thanks, these changes look fine.
[1]: https://lore.kernel.org/git/CAPig+cR+1bxgitSmJ47PxD=CPxJjMh5Vm+zRdVU8iEo9pvtutw@mail.gmail.com/
[2]: https://lore.kernel.org/git/CAPig+cTC4TUK2NXFmP6ymEYYjYAmCSd53dzFhKn0ido8x6uh1Q@mail.gmail.com/
[3]: https://lore.kernel.org/git/20230202202557.19297-1-kostya.farber@gmail.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-05 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-04 20:41 [PATCH] t5000: modernise archive and :(glob) test Kostya Farber
2023-02-05 18:10 ` Eric Sunshine
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).