From: Eric Sunshine <sunshine@sunshineco.com>
To: Kostya Farber <kostya.farber@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t5000: modernise archive and :(glob) test
Date: Sun, 5 Feb 2023 13:10:17 -0500 [thread overview]
Message-ID: <CAPig+cQrGHuqmmWvqBNs2PKEp_KPrVKVcZyJ3u7akS4BrpA4dw@mail.gmail.com> (raw)
In-Reply-To: <20230204204124.80741-1-kostya.farber@gmail.com>
On Sat, Feb 4, 2023 at 3:54 PM Kostya Farber <kostya.farber@gmail.com> wrote:
> To match present day coding guiding codelines let's:
We can probably just say "coding guidelines" rather than "coding
guiding codelines".
> - use <<-EOF, so we can indent all lines to the
> the same level for this test
>
> - use <<\EOF to notify the reader that no interpolation
> is exepected in the body
s/exepected/expected/
> Signed-off-by: Kostya Farber <kostya.farber@gmail.com>
> ---
For other reviewers who may not have been following along, this is a
suggested replacement[1] to a rejected (by me[2]) GSoC
microproject[3].
> diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
> @@ -402,11 +402,11 @@ test_expect_success GZIP 'extract tgz file (external gzip)' '
> test_expect_success 'archive and :(glob)' '
> git archive -v HEAD -- ":(glob)**/sh" >/dev/null 2>actual &&
> - cat >expect <<EOF &&
> -a/
> -a/bin/
> -a/bin/sh
> -EOF
> + cat >expect <<-\EOF &&
> + a/
> + a/bin/
> + a/bin/sh
> + EOF
> test_cmp expect actual
> '
Thanks, these changes look fine.
[1]: https://lore.kernel.org/git/CAPig+cR+1bxgitSmJ47PxD=CPxJjMh5Vm+zRdVU8iEo9pvtutw@mail.gmail.com/
[2]: https://lore.kernel.org/git/CAPig+cTC4TUK2NXFmP6ymEYYjYAmCSd53dzFhKn0ido8x6uh1Q@mail.gmail.com/
[3]: https://lore.kernel.org/git/20230202202557.19297-1-kostya.farber@gmail.com/
prev parent reply other threads:[~2023-02-05 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 20:41 [PATCH] t5000: modernise archive and :(glob) test Kostya Farber
2023-02-05 18:10 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQrGHuqmmWvqBNs2PKEp_KPrVKVcZyJ3u7akS4BrpA4dw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=kostya.farber@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).