From: Christian Couder <christian.couder@gmail.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v5 08/10] sha1_file: support lazily fetching missing objects
Date: Sat, 2 Dec 2017 19:29:31 +0100 [thread overview]
Message-ID: <CAP8UFD2Q075aKG0yEbOy-W2+NSa6n8AEVu=yWn9q=xSnQwn5=g@mail.gmail.com> (raw)
In-Reply-To: <20171121210720.21376-9-git@jeffhostetler.com>
On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
> From: Jonathan Tan <jonathantanmy@google.com>
> diff --git a/sha1_file.c b/sha1_file.c
> index 10c3a00..fc7718a 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -29,6 +29,7 @@
> #include "mergesort.h"
> #include "quote.h"
> #include "packfile.h"
> +#include "fetch-object.h"
>
> const unsigned char null_sha1[GIT_MAX_RAWSZ];
> const struct object_id null_oid;
> @@ -1144,6 +1145,8 @@ static int sha1_loose_object_info(const unsigned char *sha1,
> return (status < 0) ? status : 0;
> }
>
> +int fetch_if_missing = 1;
> +
> int sha1_object_info_extended(const unsigned char *sha1, struct object_info *oi, unsigned flags)
> {
> static struct object_info blank_oi = OBJECT_INFO_INIT;
> @@ -1152,6 +1155,7 @@ int sha1_object_info_extended(const unsigned char *sha1, struct object_info *oi,
> const unsigned char *real = (flags & OBJECT_INFO_LOOKUP_REPLACE) ?
> lookup_replace_object(sha1) :
> sha1;
> + int already_retried = 0;
>
> if (!oi)
> oi = &blank_oi;
> @@ -1176,28 +1180,36 @@ int sha1_object_info_extended(const unsigned char *sha1, struct object_info *oi,
> }
> }
>
> - if (!find_pack_entry(real, &e)) {
> - /* Most likely it's a loose object. */
> - if (!sha1_loose_object_info(real, oi, flags))
> - return 0;
> +retry:
> + if (find_pack_entry(real, &e))
> + goto found_packed;
>
> - /* Not a loose object; someone else may have just packed it. */
> - if (flags & OBJECT_INFO_QUICK) {
> - return -1;
> - } else {
> - reprepare_packed_git();
> - if (!find_pack_entry(real, &e))
> - return -1;
> - }
> + /* Most likely it's a loose object. */
> + if (!sha1_loose_object_info(real, oi, flags))
> + return 0;
> +
> + /* Not a loose object; someone else may have just packed it. */
> + reprepare_packed_git();
> + if (find_pack_entry(real, &e))
> + goto found_packed;
> +
> + /* Check if it is a missing object */
> + if (fetch_if_missing && repository_format_partial_clone &&
> + !already_retried) {
> + fetch_object(repository_format_partial_clone, real);
> + already_retried = 1;
> + goto retry;
> }
>
> + return -1;
> +
> +found_packed:
> if (oi == &blank_oi)
> /*
> * We know that the caller doesn't actually need the
> * information below, so return early.
> */
> return 0;
> -
> rtype = packed_object_info(e.p, e.offset, oi);
> if (rtype < 0) {
> mark_bad_packed_object(e.p, real);
The above is adding 2 different gotos into this function while there
are quite simple ways to avoid them. See
https://public-inbox.org/git/CAP8UFD2THRj7+RXmismUtUOpXQv4wM7aZsejpd_FHEOycP+ZJA@mail.gmail.com/
and the follow up email in the thread.
next prev parent reply other threads:[~2017-12-02 18:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 21:07 [PATCH v5 00/10] Partial clone part 2: fsck and promisors Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 01/10] extension.partialclone: introduce partial clone extension Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 02/10] fsck: introduce partialclone extension Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 03/10] fsck: support refs pointing to promisor objects Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 04/10] fsck: support referenced " Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 05/10] fsck: support promisor objects as CLI argument Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 06/10] index-pack: refactor writing of .keep files Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 07/10] introduce fetch-object: fetch one promisor object Jeff Hostetler
2017-12-02 20:33 ` Christian Couder
2017-12-05 16:18 ` Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 08/10] sha1_file: support lazily fetching missing objects Jeff Hostetler
2017-12-02 18:29 ` Christian Couder [this message]
2017-12-05 16:02 ` Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 09/10] rev-list: support termination at promisor objects Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 10/10] gc: do not repack promisor packfiles Jeff Hostetler
2017-12-02 17:39 ` Christian Couder
2017-12-05 15:45 ` Jeff Hostetler
2017-11-22 5:25 ` [PATCH v5 00/10] Partial clone part 2: fsck and promisors Junio C Hamano
2017-11-22 18:00 ` Jonathan Tan
2017-11-22 21:42 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD2Q075aKG0yEbOy-W2+NSa6n8AEVu=yWn9q=xSnQwn5=g@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).