From: Jeff Hostetler <git@jeffhostetler.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Jonathan Tan <jonathantanmy@google.com>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v5 10/10] gc: do not repack promisor packfiles
Date: Tue, 5 Dec 2017 10:45:28 -0500 [thread overview]
Message-ID: <12409f04-5dd3-a823-6193-e17e9157ae16@jeffhostetler.com> (raw)
In-Reply-To: <CAP8UFD10YsCQtiFtLtzQ-PKsY93QaDC4zsO+k1tfauBs8ntt1w@mail.gmail.com>
On 12/2/2017 12:39 PM, Christian Couder wrote:
> On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
>> From: Jonathan Tan <jonathantanmy@google.com>
>
>> pack_as_from_promisor () {
>> HASH=$(git -C repo pack-objects .git/objects/pack/pack) &&
>> >repo/.git/objects/pack/pack-$HASH.promisor
>> + echo $HASH
>> }
>
> Now the exit code of the above function will always be the exit code
> of "echo $HASH".
> It seems to me that it would be better to add "&&" at the end of the
> line above the "echo $HASH".
>
Fixed. Thanks.
Jeff
next prev parent reply other threads:[~2017-12-05 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 21:07 [PATCH v5 00/10] Partial clone part 2: fsck and promisors Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 01/10] extension.partialclone: introduce partial clone extension Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 02/10] fsck: introduce partialclone extension Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 03/10] fsck: support refs pointing to promisor objects Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 04/10] fsck: support referenced " Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 05/10] fsck: support promisor objects as CLI argument Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 06/10] index-pack: refactor writing of .keep files Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 07/10] introduce fetch-object: fetch one promisor object Jeff Hostetler
2017-12-02 20:33 ` Christian Couder
2017-12-05 16:18 ` Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 08/10] sha1_file: support lazily fetching missing objects Jeff Hostetler
2017-12-02 18:29 ` Christian Couder
2017-12-05 16:02 ` Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 09/10] rev-list: support termination at promisor objects Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 10/10] gc: do not repack promisor packfiles Jeff Hostetler
2017-12-02 17:39 ` Christian Couder
2017-12-05 15:45 ` Jeff Hostetler [this message]
2017-11-22 5:25 ` [PATCH v5 00/10] Partial clone part 2: fsck and promisors Junio C Hamano
2017-11-22 18:00 ` Jonathan Tan
2017-11-22 21:42 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12409f04-5dd3-a823-6193-e17e9157ae16@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).