From: Christian Couder <christian.couder@gmail.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v5 07/10] introduce fetch-object: fetch one promisor object
Date: Sat, 2 Dec 2017 21:33:54 +0100 [thread overview]
Message-ID: <CAP8UFD1dm4EJXU3VdgGMDawy3jCT20hHQXwZxvtwy7_eomz9Fw@mail.gmail.com> (raw)
In-Reply-To: <20171121210720.21376-8-git@jeffhostetler.com>
On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
> From: Jonathan Tan <jonathantanmy@google.com>
> +void fetch_object(const char *remote_name, const unsigned char *sha1)
> +{
> + struct remote *remote;
> + struct transport *transport;
> + struct ref *ref;
> +
> + remote = remote_get(remote_name);
> + if (!remote->url[0])
> + die(_("Remote with no URL"));
> + transport = transport_get(remote, remote->url[0]);
> +
> + ref = alloc_ref(sha1_to_hex(sha1));
> + hashcpy(ref->old_oid.hash, sha1);
> + transport_set_option(transport, TRANS_OPT_FROM_PROMISOR, "1");
> + transport_set_option(transport, TRANS_OPT_NO_HAVES, "1");
> + transport_fetch_refs(transport, ref);
> +}
I think it would be interesting to return what transport_fetch_refs()
returns, so that a caller could know if an error happened.
next prev parent reply other threads:[~2017-12-02 20:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 21:07 [PATCH v5 00/10] Partial clone part 2: fsck and promisors Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 01/10] extension.partialclone: introduce partial clone extension Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 02/10] fsck: introduce partialclone extension Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 03/10] fsck: support refs pointing to promisor objects Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 04/10] fsck: support referenced " Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 05/10] fsck: support promisor objects as CLI argument Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 06/10] index-pack: refactor writing of .keep files Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 07/10] introduce fetch-object: fetch one promisor object Jeff Hostetler
2017-12-02 20:33 ` Christian Couder [this message]
2017-12-05 16:18 ` Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 08/10] sha1_file: support lazily fetching missing objects Jeff Hostetler
2017-12-02 18:29 ` Christian Couder
2017-12-05 16:02 ` Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 09/10] rev-list: support termination at promisor objects Jeff Hostetler
2017-11-21 21:07 ` [PATCH v5 10/10] gc: do not repack promisor packfiles Jeff Hostetler
2017-12-02 17:39 ` Christian Couder
2017-12-05 15:45 ` Jeff Hostetler
2017-11-22 5:25 ` [PATCH v5 00/10] Partial clone part 2: fsck and promisors Junio C Hamano
2017-11-22 18:00 ` Jonathan Tan
2017-11-22 21:42 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD1dm4EJXU3VdgGMDawy3jCT20hHQXwZxvtwy7_eomz9Fw@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).