From: Ray Chen <rchen@cs.umd.edu>
To: Eric Wong <normalperson@yhbt.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Ilya Basin <basinilya@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()
Date: Thu, 2 May 2013 14:59:58 -0400 [thread overview]
Message-ID: <CANtO-4OYjKpGSAxjKubvubGoXgdkkiZ9yK1unW1wrcONa3ErsQ@mail.gmail.com> (raw)
In-Reply-To: <20130502024926.GA12172@dcvr.yhbt.net>
On Wed, May 1, 2013 at 10:49 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Junio C Hamano <gitster@pobox.com> wrote:
>
>> Eric Wong <normalperson@yhbt.net> writes:
>
>> That however is not a property of the directory containing it (or
>> the path to that .gitignore file) that is valid throughout the
>> history of the project. It is a property of a specific tree object
>> (or you could say it is a property of the revision). When at some
>> point in the history the upstream project adds .gitignore there
>> because many people use git-svn to contribute to their project, it
>> stops to be "should not be pushed back".
>>
>> So it seems to me that the information this "placeholder added"
>> thing wants to express belongs to the tree object (and .gitignore
>> file itself is a natural place to have that information).
>
> Perhaps that was the better way to go...
>
> How would (the presumably few) existing users of this feature be
> affected?
>
> Currently with the config file, there are problems with interop between
> git-svn users that do git <-> git repo sharing, an updated version with
> the "placeholder added" .gitignore would allow git <-> git repo sharing,
> but only between users of newer git versions. Perhaps that's fine and
> better than the current situation.
The original patch was geared towards increasing the fidelity of a
one-time svn->git migration (ie. where svn won't be used anymore). I
recall investigating a method to enforce this by disallowing future
git-svn fetches, but I can't remember if I was successful. Given this
perspective, I'm not sure that existing users need to be supported.
Then, as Junio mentions, future versions of git that store placeholder
info in the tree/file object could open the possibility of proper
git<->git sharing and resync with the original svn repo.
- Ray
next prev parent reply other threads:[~2013-05-02 19:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 5:09 [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list() Ilya Basin
2013-05-01 8:31 ` Re[2]: " Ilya Basin
2013-05-01 17:09 ` Junio C Hamano
2013-05-01 19:51 ` Re[2]: " Ilya Basin
2013-05-01 21:30 ` Eric Wong
2013-05-01 21:53 ` Junio C Hamano
2013-05-02 2:49 ` Eric Wong
2013-05-02 17:31 ` Re[2]: " Ilya Basin
2013-05-02 20:40 ` Eric Wong
2013-05-03 5:26 ` Re[2]: " Ilya Basin
2013-05-03 6:42 ` Re[3]: " Ilya Basin
2013-05-06 8:14 ` Re[4]: " Ilya Basin
2013-05-06 8:58 ` Re[3]: " Ilya Basin
2013-05-09 1:05 ` Eric Wong
2013-05-28 12:57 ` Re[4]: " Ilya Basin
2013-05-02 18:59 ` Ray Chen [this message]
2013-05-02 3:51 ` Re[2]: " Ilya Basin
2013-05-02 20:09 ` Eric Wong
-- strict thread matches above, loose matches on Subject: below --
2013-04-30 17:37 Ilya Basin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANtO-4OYjKpGSAxjKubvubGoXgdkkiZ9yK1unW1wrcONa3ErsQ@mail.gmail.com \
--to=rchen@cs.umd.edu \
--cc=basinilya@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).