From: Eric Wong <normalperson@yhbt.net>
To: Ilya Basin <basinilya@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git mailing list <git@vger.kernel.org>,
Ray Chen <rchen@cs.umd.edu>
Subject: Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()
Date: Wed, 1 May 2013 21:30:31 +0000 [thread overview]
Message-ID: <20130501213031.GA13056@dcvr.yhbt.net> (raw)
In-Reply-To: <455264907.20130501235104@gmail.com>
Ilya Basin <basinilya@gmail.com> wrote:
> JCH> comment line "# added by git-svn only to keep the directory" and
> JCH> consider a directory that has nothing but .gitignore that consists
> JCH> of only that exact comment line an "added placeholder" directory to
> JCH> work it around.
> Sounds good, but it's not I who decided to use the config file.
Ugh, I didn't review Ray's original commit closely enough to notice
this :x
Perhaps we should migrate users to use YAML storage for this, instead
(we already use YAML for Git::SVN::Memoize::YAML).
Fwiw, I've never been a fan of placeholders only accepted it since it's
off-by-default but it worked well enough for Ray.
My personal philosophy has always been: git svn users should leave
no trace or indication they're using a non-standard SVN client.
next prev parent reply other threads:[~2013-05-01 21:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 5:09 [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list() Ilya Basin
2013-05-01 8:31 ` Re[2]: " Ilya Basin
2013-05-01 17:09 ` Junio C Hamano
2013-05-01 19:51 ` Re[2]: " Ilya Basin
2013-05-01 21:30 ` Eric Wong [this message]
2013-05-01 21:53 ` Junio C Hamano
2013-05-02 2:49 ` Eric Wong
2013-05-02 17:31 ` Re[2]: " Ilya Basin
2013-05-02 20:40 ` Eric Wong
2013-05-03 5:26 ` Re[2]: " Ilya Basin
2013-05-03 6:42 ` Re[3]: " Ilya Basin
2013-05-06 8:14 ` Re[4]: " Ilya Basin
2013-05-06 8:58 ` Re[3]: " Ilya Basin
2013-05-09 1:05 ` Eric Wong
2013-05-28 12:57 ` Re[4]: " Ilya Basin
2013-05-02 18:59 ` Ray Chen
2013-05-02 3:51 ` Re[2]: " Ilya Basin
2013-05-02 20:09 ` Eric Wong
-- strict thread matches above, loose matches on Subject: below --
2013-04-30 17:37 Ilya Basin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501213031.GA13056@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=basinilya@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rchen@cs.umd.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).