From: Ilya Basin <basinilya@gmail.com>
To: Git mailing list <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Ray Chen <rchen@cs.umd.edu>,
Eric Wong <normalperson@yhbt.net>
Subject: Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()
Date: Wed, 1 May 2013 12:31:53 +0400 [thread overview]
Message-ID: <1409591910.20130501123153@gmail.com> (raw)
In-Reply-To: <1438528085.20130501090926@gmail.com>
IB> In my repo the placeholders change too often (in 1/4 commits). I'm
IB> thinking of using:
IB> 'git config --unset "svn-remote.$repo_id.added-placeholder" path_regex'
IB> instead of full rewrite.
I need your help. There are still problems:
$ grep "define MAX_MATCHES" ~/builds/git/git-git/config.c
#define MAX_MATCHES 8192
$ grep added-placeholder .git/config | wc -l
4430
1/4 commits change the list of placeholders, usually 1 folder changes.
Clearing and re-adding the entries to the config takes ~1 minute.
Pressing Ctrl-C at this time makes the list incomplete.
Re-adding all entries using 'config --add' is slow.
Does Git::config package have tools to modify multiple entries at once?
I wonder why 'git config --get-all' is used instead of some
Git::config routine.
Otherwise, to make this atomic, I think, the modification should be made
to a backup config file, then it should replace .git/config (or
rewrite it with signals blocked).
How to determine GIT_DIR from Fetcher.pm?
maybe I can simply append a duplicate section
'[svn-remote "svn"]'. But then I would need to escape the values
myself.
Also, git --unset-all leaves one empty section: '[svn-remote "svn"]'
Is it a bug?
--
next prev parent reply other threads:[~2013-05-01 8:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 5:09 [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list() Ilya Basin
2013-05-01 8:31 ` Ilya Basin [this message]
2013-05-01 17:09 ` Junio C Hamano
2013-05-01 19:51 ` Re[2]: " Ilya Basin
2013-05-01 21:30 ` Eric Wong
2013-05-01 21:53 ` Junio C Hamano
2013-05-02 2:49 ` Eric Wong
2013-05-02 17:31 ` Re[2]: " Ilya Basin
2013-05-02 20:40 ` Eric Wong
2013-05-03 5:26 ` Re[2]: " Ilya Basin
2013-05-03 6:42 ` Re[3]: " Ilya Basin
2013-05-06 8:14 ` Re[4]: " Ilya Basin
2013-05-06 8:58 ` Re[3]: " Ilya Basin
2013-05-09 1:05 ` Eric Wong
2013-05-28 12:57 ` Re[4]: " Ilya Basin
2013-05-02 18:59 ` Ray Chen
2013-05-02 3:51 ` Re[2]: " Ilya Basin
2013-05-02 20:09 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409591910.20130501123153@gmail.com \
--to=basinilya@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=rchen@cs.umd.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).