From: "Miriam R." <mirucam@gmail.com>
To: l.s.r@web.de
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static
Date: Sun, 9 Feb 2020 10:59:47 +0100 [thread overview]
Message-ID: <CAN7CjDB8NKQg279WjT6kWNaENiBRSEqztL0g9HbnS6RB_ZV7+A@mail.gmail.com> (raw)
In-Reply-To: <4550b9a5-74ef-2739-990b-6f41f3319129@web.de>
Hi,
El sáb., 8 feb. 2020 a las 11:55, René Scharfe (<l.s.r@web.de>) escribió:
>
> Am 08.02.20 um 10:06 schrieb Miriam Rubio:
> > From: Pranit Bauva <pranit.bauva@gmail.com>
> >
> > Removes the `static` keyword from `exists_in_PATH()` function
> > and declares the function in `run-command.h` file.
> > The function will be used in bisect_visualize() in a later
> > commit.
>
> I couldn't find the mentioned later commit in this series. Do you
> actually still need to export exists_in_PATH()?
This series is part of a bigger patch series
(https://public-inbox.org/git/20200120143800.900-1-mirucam@gmail.com/)
that has been split as a suggestion of a reviewer in order to be
easily reviewed.
This first part is formed of preparatory/clean-up patches and all
`bisect.c` libification work. The actual patch is one of the
preparatory patches and the function will be used in the upcoming
patch series.
>
> And if yes: locate_in_PATH() splits PATH by colon. That means it
> doesn't work on Windows, where the paths are separated by semicolons.
> exists_in_PATH() wraps it, so it shares that limitation. Wouldn't that
> cause issues for your use?
Thank you, for point that out. I will check this.
Best,
Miriam
>
> René
next prev parent reply other threads:[~2020-02-09 10:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 9:06 [Outreachy] [PATCH v3 00/13] Finish converting git bisect to C part 1 Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 01/13] bisect--helper: convert `vocab_*` char pointers to char arrays Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 02/13] bisect--helper: change `retval` to `res` Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 03/13] bisect: use the standard 'if (!var)' way to check for 0 Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static Miriam Rubio
2020-02-08 10:55 ` René Scharfe
2020-02-09 9:59 ` Miriam R. [this message]
[not found] ` <CAN7CjDC46xTHBxvkbWvYfUt91Z6sdPP1tT3rJBoc4x6QCrv+2A@mail.gmail.com>
[not found] ` <47b51655-6373-0d5f-1397-8cbbb73d6661@web.de>
2020-02-10 16:05 ` Miriam R.
2020-02-09 23:16 ` Taylor Blau
2020-02-08 9:06 ` [PATCH v3 05/13] bisect--helper: introduce new `decide_next()` function Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 06/13] bisect: add enum to represent bisect returning codes Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 07/13] bisect--helper: return error codes from `cmd_bisect__helper()` Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 08/13] bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and its dependents Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 09/13] bisect: libify `bisect_checkout` Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 10/13] bisect: libify `check_merge_bases` and its dependents Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 11/13] bisect: libify `check_good_are_ancestors_of_bad` " Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 12/13] bisect: libify `handle_bad_merge_base` " Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 13/13] bisect: libify `bisect_next_all` Miriam Rubio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN7CjDB8NKQg279WjT6kWNaENiBRSEqztL0g9HbnS6RB_ZV7+A@mail.gmail.com \
--to=mirucam@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).