git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Miriam Rubio <mirucam@gmail.com>
To: git@vger.kernel.org
Cc: Miriam Rubio <mirucam@gmail.com>
Subject: [Outreachy] [PATCH v3 00/13] Finish converting git bisect to C part 1
Date: Sat,  8 Feb 2020 10:06:51 +0100
Message-ID: <20200208090704.26506-1-mirucam@gmail.com> (raw)

These patches correspond to a first part of patch series 
of Outreachy project "Finish converting `git bisect` from shell to C" 
started by Pranit Bauva and Tanushree Tumane
(https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
continued by me.

This first part is formed of preparatory/clean-up patches and all 
`bisect.c` libification work. 

I would like to thank Johannes Schindelin and Junio Hamano for reviewing
the patch series.

These patch series emails were generated from:
https://gitlab.com/mirucam/git/commits/git-bisect-work-part1-v3

--- Changes since v2 Finish converting git bisect to C part 1 patch series ---

General changes
---------------

* Rebase on master branch: de93cc14ab (The third batch for 2.26, 2020-02-05).
* Amend commit messages.
* Add an enum to represent bisecting error codes.

Specific changes
----------------

[5/13] bisect--helper: introduce new `decide_next()` function

* Change const char* types to char* and fix `free()` calls.

--

[6/13] bisect: add enum to represent bisect returning codes

* New patch that adds an enum to represent bisecting error codes.

--

[7/13] bisect--helper: return error codes from `cmd_bisect__helper()`

* New patch split from `libify `check_good_are_ancestors_of_bad` and its 
dependents`.
* Change code in return for readability.

--

[8/13] bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` 
and its dependents

* Remove comments.

--

[9/13] bisect: libify `bisect_checkout`

* Fix declaration block.
* Change code in return for readability.
* Add comments.

--

[11/13] bisect: libify `check_good_are_ancestors_of_bad` and its 
dependents

* Fix brace location.

--

Miriam Rubio (3):
  bisect--helper: convert `vocab_*` char pointers to char arrays
  bisect: use the standard 'if (!var)' way to check for 0
  bisect: add enum to represent bisect returning codes

Pranit Bauva (8):
  run-command: make `exists_in_PATH()` non-static
  bisect--helper: return error codes from `cmd_bisect__helper()`
  bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and
    its dependents
  bisect: libify `bisect_checkout`
  bisect: libify `check_merge_bases` and its dependents
  bisect: libify `check_good_are_ancestors_of_bad` and its dependents
  bisect: libify `handle_bad_merge_base` and its dependents
  bisect: libify `bisect_next_all`

Tanushree Tumane (2):
  bisect--helper: change `retval` to `res`
  bisect--helper: introduce new `decide_next()` function

 bisect.c                 | 135 +++++++++++++++++++++++++++------------
 bisect.h                 |  29 ++++++++-
 builtin/bisect--helper.c | 123 +++++++++++++++++++----------------
 run-command.c            |   2 +-
 run-command.h            |  11 ++++
 5 files changed, 201 insertions(+), 99 deletions(-)

-- 
2.25.0


             reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-08  9:06 Miriam Rubio [this message]
2020-02-08  9:06 ` [PATCH v3 01/13] bisect--helper: convert `vocab_*` char pointers to char arrays Miriam Rubio
2020-02-08  9:06 ` [PATCH v3 02/13] bisect--helper: change `retval` to `res` Miriam Rubio
2020-02-08  9:06 ` [PATCH v3 03/13] bisect: use the standard 'if (!var)' way to check for 0 Miriam Rubio
2020-02-08  9:06 ` [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static Miriam Rubio
2020-02-08 10:55   ` René Scharfe
2020-02-09  9:59     ` Miriam R.
     [not found]       ` <CAN7CjDC46xTHBxvkbWvYfUt91Z6sdPP1tT3rJBoc4x6QCrv+2A@mail.gmail.com>
     [not found]         ` <47b51655-6373-0d5f-1397-8cbbb73d6661@web.de>
2020-02-10 16:05           ` Miriam R.
2020-02-09 23:16   ` Taylor Blau
2020-02-08  9:06 ` [PATCH v3 05/13] bisect--helper: introduce new `decide_next()` function Miriam Rubio
2020-02-08  9:06 ` [PATCH v3 06/13] bisect: add enum to represent bisect returning codes Miriam Rubio
2020-02-08  9:06 ` [PATCH v3 07/13] bisect--helper: return error codes from `cmd_bisect__helper()` Miriam Rubio
2020-02-08  9:06 ` [PATCH v3 08/13] bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and its dependents Miriam Rubio
2020-02-08  9:07 ` [PATCH v3 09/13] bisect: libify `bisect_checkout` Miriam Rubio
2020-02-08  9:07 ` [PATCH v3 10/13] bisect: libify `check_merge_bases` and its dependents Miriam Rubio
2020-02-08  9:07 ` [PATCH v3 11/13] bisect: libify `check_good_are_ancestors_of_bad` " Miriam Rubio
2020-02-08  9:07 ` [PATCH v3 12/13] bisect: libify `handle_bad_merge_base` " Miriam Rubio
2020-02-08  9:07 ` [PATCH v3 13/13] bisect: libify `bisect_next_all` Miriam Rubio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200208090704.26506-1-mirucam@gmail.com \
    --to=mirucam@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git