From: "Miriam R." <firstname.lastname@example.org>
To: "René Scharfe" <email@example.com>
Cc: git <firstname.lastname@example.org>
Subject: Re: [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static
Date: Mon, 10 Feb 2020 17:05:31 +0100 [thread overview]
Message-ID: <CAN7CjDB=n=wfkEb=9kR7RKRm9oUAOsyxYJeU1w5MW=QH40kJVw@mail.gmail.com> (raw)
El lun., 10 feb. 2020 a las 16:43, René Scharfe (<email@example.com>) escribió:
> Hello Miriam,
> did you remove the Git mailing list from cc: intentionally?
Maybe I clicked reply, instead reply all. Sorry.
It is included in CC now.
> Am 10.02.20 um 12:16 schrieb Miriam R.:
> > El dom., 9 feb. 2020 a las 10:59, Miriam R. (<firstname.lastname@example.org>) escribió:
> >> El sáb., 8 feb. 2020 a las 11:55, René Scharfe (<email@example.com>) escribió:
> >>> And if yes: locate_in_PATH() splits PATH by colon. That means it
> >>> doesn't work on Windows, where the paths are separated by semicolons.
> >>> exists_in_PATH() wraps it, so it shares that limitation. Wouldn't that
> >>> cause issues for your use?
> >> Thank you, for point that out. I will check this.
> > This function is used only to test if gitk exists. But as gitk does not work
> > on Windows, then I think it is all ok because the evaluation is going to
> > return false and nothing has to be changed.
> Now I'm confused, because I do use gitk on Windows. The third
> screenshot on https://gitforwindows.org/ shows it as well, so you don't
> have to just take my word on it.
Ohh, as I'm not a Windows user, and after some google searches it
seems to me it doesn't. It is clear that I was not asking the correct
things, hehe. Thank you for the clarification.
> > Also, as this patch is not really needed for this part1, I will move
> > it to the upcoming patch series.
> That makes sense.
> I guess it's to used in the C equivalent of the Shell function
> bisect_visualize(), which resolves gitk using type, calls it if it's
> found and falls back to git log if it isn't.
>Why not try to exec gitk
> and fall back to git log if that fails?
It seems a good solution for me :)
Thank you for reviewing.
next prev parent reply other threads:[~2020-02-10 16:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 9:06 [Outreachy] [PATCH v3 00/13] Finish converting git bisect to C part 1 Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 01/13] bisect--helper: convert `vocab_*` char pointers to char arrays Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 02/13] bisect--helper: change `retval` to `res` Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 03/13] bisect: use the standard 'if (!var)' way to check for 0 Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static Miriam Rubio
2020-02-08 10:55 ` René Scharfe
2020-02-09 9:59 ` Miriam R.
[not found] ` <CAN7CjDC46xTHBxvkbWvYfUt91Z6sdPP1tT3rJBoc4x6QCrv+2A@mail.gmail.com>
[not found] ` <firstname.lastname@example.org>
2020-02-10 16:05 ` Miriam R. [this message]
2020-02-09 23:16 ` Taylor Blau
2020-02-08 9:06 ` [PATCH v3 05/13] bisect--helper: introduce new `decide_next()` function Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 06/13] bisect: add enum to represent bisect returning codes Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 07/13] bisect--helper: return error codes from `cmd_bisect__helper()` Miriam Rubio
2020-02-08 9:06 ` [PATCH v3 08/13] bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and its dependents Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 09/13] bisect: libify `bisect_checkout` Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 10/13] bisect: libify `check_merge_bases` and its dependents Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 11/13] bisect: libify `check_good_are_ancestors_of_bad` " Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 12/13] bisect: libify `handle_bad_merge_base` " Miriam Rubio
2020-02-08 9:07 ` [PATCH v3 13/13] bisect: libify `bisect_next_all` Miriam Rubio
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).