From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v5] completion: add new __git_complete helper
Date: Mon, 14 May 2012 19:55:09 +0200 [thread overview]
Message-ID: <CAMP44s1pb+J_SAzZ66QVcWq4V=LauUQ2VmzMD8KBtnhjubkkVg@mail.gmail.com> (raw)
In-Reply-To: <7vvcjyhd5n.fsf@alter.siamese.dyndns.org>
On Mon, May 14, 2012 at 7:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> This simplifies the completions, and would make it easier to define
>> aliases in the future.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>> contrib/completion/git-completion.bash | 70 +++++++++++++++-----------------
>> t/t9902-completion.sh | 2 +-
>> 2 files changed, 34 insertions(+), 38 deletions(-)
>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 9f56ec7..d60bb8a 100755
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2603,21 +2603,6 @@ _git ()
>> {
>> local i c=1 command __git_dir
>>
>> - if [[ -n ${ZSH_VERSION-} ]]; then
>> - emulate -L bash
>> - setopt KSH_TYPESET
>> -
>> - # workaround zsh's bug that leaves 'words' as a special
>> - # variable in versions < 4.3.12
>> - typeset -h words
>> -
>> - # workaround zsh's bug that quotes spaces in the COMPREPLY
>> - # array if IFS doesn't contain spaces.
>> - typeset -h IFS
>> - fi
>> -
>> - local cur words cword prev
>> - _get_comp_words_by_ref -n =: cur words cword prev
>> while [ $c -lt $cword ]; do
>> i="${words[c]}"
>> case "$i" in
>> @@ -2667,22 +2652,6 @@ _git ()
>>
>> _gitk ()
>> {
>> - if [[ -n ${ZSH_VERSION-} ]]; then
>> - emulate -L bash
>> - setopt KSH_TYPESET
>> -
>> - # workaround zsh's bug that leaves 'words' as a special
>> - # variable in versions < 4.3.12
>> - typeset -h words
>> -
>> - # workaround zsh's bug that quotes spaces in the COMPREPLY
>> - # array if IFS doesn't contain spaces.
>> - typeset -h IFS
>> - fi
>> -
>> - local cur words cword prev
>> - _get_comp_words_by_ref -n =: cur words cword prev
>> -
>> @@ -2703,16 +2672,43 @@ _gitk ()
>> __git_complete_revlist
>> }
>>
>> -complete -o bashdefault -o default -o nospace -F _git git 2>/dev/null \
>> - || complete -o default -o nospace -F _git git
>> -complete -o bashdefault -o default -o nospace -F _gitk gitk 2>/dev/null \
>> - || complete -o default -o nospace -F _gitk gitk
>
> Nice code reduction by moving the duplicated code into the new helpers ;-)
>
>> +__git_func_wrap ()
>> +{
>> + if [[ -n ${ZSH_VERSION-} ]]; then
>> + emulate -L bash
>> + setopt KSH_TYPESET
>> +
>> + # workaround zsh's bug that leaves 'words' as a special
>> + # variable in versions < 4.3.12
>> + typeset -h words
>> +
>> + # workaround zsh's bug that quotes spaces in the COMPREPLY
>> + # array if IFS doesn't contain spaces.
>> + typeset -h IFS
>> + fi
>> + local cur words cword prev
>> + _get_comp_words_by_ref -n =: cur words cword prev
>> + $1
>> +}
>> +
>> +# Setup completion for certain functions defined above by setting common
>> +# variables and workarounds.
>> +# This is NOT a public function; use at your own risk.
>> +__git_complete ()
>> +{
>> + local wrapper="__git_wrap${2}"
>> + eval "$wrapper () { __git_func_wrap $2 ; }"
>> + complete -o bashdefault -o default -o nospace -F $wrapper $1 2>/dev/null \
>> + || complete -o default -o nospace -F $wrapper $1
>> +}
>> +
>> +__git_complete git _git
>> +__git_complete gitk _gitk
>
> It makes my stomach queasy whenever I see $var not in double quotes that
> forces me to guess (and trace to verify if the codepath is what I really
> care about) if any value with $IFS in it could be used there, so even when
> they are known to be safe, I'd prefer to see either explicit quotes or
> comment that says what are expected in $1 and $2.
Which ones? These?
>> + $1
>> + complete -o bashdefault -o default -o nospace -F $wrapper $1 2>/dev/null \
>> + || complete -o default -o nospace -F $wrapper $1
So you want:
"$1"
complete -o bashdefault -o default -o nospace -F "$wrapper" "$1" 2>/dev/null \
|| complete -o default -o nospace -F "$wrapper" "$1"
I wouldn't object to the arguments of complete, but the function call
seems totally unintuitive to me like that.
--
Felipe Contreras
next prev parent reply other threads:[~2012-05-14 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:35 [PATCH v5] completion: add new __git_complete helper Felipe Contreras
2012-05-14 14:38 ` Felipe Contreras
2012-05-14 17:43 ` Junio C Hamano
2012-05-14 17:55 ` Felipe Contreras [this message]
2012-05-14 18:13 ` Junio C Hamano
2012-05-14 18:30 ` Felipe Contreras
2012-05-14 19:09 ` Junio C Hamano
2012-05-14 19:53 ` Felipe Contreras
2012-05-15 17:01 ` Junio C Hamano
2012-05-15 17:03 ` Junio C Hamano
2012-05-16 15:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s1pb+J_SAzZ66QVcWq4V=LauUQ2VmzMD8KBtnhjubkkVg@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).