From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v5] completion: add new __git_complete helper
Date: Tue, 15 May 2012 10:01:42 -0700 [thread overview]
Message-ID: <7v62bxfkeh.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s2L=s4bd-sDcY3RWLWe9=YzLgC7UavgnE6K0akMCJSK4w@mail.gmail.com> (Felipe Contreras's message of "Mon, 14 May 2012 21:53:10 +0200")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Mon, May 14, 2012 at 9:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>>> Here is my attempt to explain why none of them needs to be quoted:
>>>> ...
>>> I don't understand that.
>>
>> That was my attempt to give the readers some context to understand what
>> comes after that....
>
> I mean I don't understand this "Note that none of the variable
> reference in the implementation of this function needs dq around it."
You later say "then yeah, I agree.", so I am interpreting this "I don't
understand" to mean that you do agree that missing dq around $1, $2 and
$wrapper in the function is _not_ a problem, and you do not understand why
it needs to be explained. See below.
> I suppose you meant 'references' (as that would make it grammatically
> correct AFAICS),...
Correct.
> but I still don't understand what you are trying so
> say. That the way the arguments are used in the __git_complete
> function makes it so double quotes are irrelevant?
Correct.
> If so, then yeah, I agree.
>
> Is there something actionable?
Like adding an explanation, preferrably a better one, there, so that the
next person do not have to wonder and waste time like I did?
next prev parent reply other threads:[~2012-05-15 17:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:35 [PATCH v5] completion: add new __git_complete helper Felipe Contreras
2012-05-14 14:38 ` Felipe Contreras
2012-05-14 17:43 ` Junio C Hamano
2012-05-14 17:55 ` Felipe Contreras
2012-05-14 18:13 ` Junio C Hamano
2012-05-14 18:30 ` Felipe Contreras
2012-05-14 19:09 ` Junio C Hamano
2012-05-14 19:53 ` Felipe Contreras
2012-05-15 17:01 ` Junio C Hamano [this message]
2012-05-15 17:03 ` Junio C Hamano
2012-05-16 15:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62bxfkeh.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).