From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v5] completion: add new __git_complete helper
Date: Mon, 14 May 2012 20:30:45 +0200 [thread overview]
Message-ID: <CAMP44s1h=MPT8vx6JrGjMZWJzRjndxYKoYgo+1Y_Mmv+gWXzaQ@mail.gmail.com> (raw)
In-Reply-To: <7vmx5ahbrm.fsf@alter.siamese.dyndns.org>
On Mon, May 14, 2012 at 8:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>>>> +__git_func_wrap ()
>>>> +{
>>>> + if [[ -n ${ZSH_VERSION-} ]]; then
>>>> + emulate -L bash
>>>> + setopt KSH_TYPESET
>>>> +
>>>> + # workaround zsh's bug that leaves 'words' as a special
>>>> + # variable in versions < 4.3.12
>>>> + typeset -h words
>>>> +
>>>> + # workaround zsh's bug that quotes spaces in the COMPREPLY
>>>> + # array if IFS doesn't contain spaces.
>>>> + typeset -h IFS
>>>> + fi
>>>> + local cur words cword prev
>>>> + _get_comp_words_by_ref -n =: cur words cword prev
>>>> + $1
>>>> +}
>>>> +
>>>> +# Setup completion for certain functions defined above by setting common
>>>> +# variables and workarounds.
>>>> +# This is NOT a public function; use at your own risk.
>>>> +__git_complete ()
>>>> +{
>>>> + local wrapper="__git_wrap${2}"
>>>> + eval "$wrapper () { __git_func_wrap $2 ; }"
>>>> + complete -o bashdefault -o default -o nospace -F $wrapper $1 2>/dev/null \
>>>> + || complete -o default -o nospace -F $wrapper $1
>>>> +}
>>>> +
>>>> +__git_complete git _git
>>>> +__git_complete gitk _gitk
>>>
>>> It makes my stomach queasy whenever I see $var not in double quotes that
>>> forces me to guess (and trace to verify if the codepath is what I really
>>> care about) if any value with $IFS in it could be used there, so even when
>>> they are known to be safe, I'd prefer to see either explicit quotes or
>>> comment that says what are expected in $1 and $2.
>>
>> Which ones?
>
> All of them ;-)
>
> Here is my attempt to explain why none of them needs to be quoted:
>
> # Setup completion for certain functions defined above by setting common
> # variables and workarounds.
> # It takes two parameters:
> # - the first is the command name on the command line to complete its
> # arguments for the user;
> # - the second is a name of the completion function
> # This is NOT a public function; use at your own risk.
> #
> # Note that none of the variable reference in the implementation of this
> # function needs dq around it.
I don't understand that.
> # wrapper: the name of an internal shell function that wraps the
> # completion function $2, formed by prefixing "__git_wrap"
> # in front of it. As it has to be usable as a name of a
> # shell function, by definition there won't be $IFS characters
> # in it.
> # $1: the command name on the command line---ditto.
> # $2: the shell function name that implements the completion-ditto.
So in short; because the variables are used as function/command names.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-05-14 18:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:35 [PATCH v5] completion: add new __git_complete helper Felipe Contreras
2012-05-14 14:38 ` Felipe Contreras
2012-05-14 17:43 ` Junio C Hamano
2012-05-14 17:55 ` Felipe Contreras
2012-05-14 18:13 ` Junio C Hamano
2012-05-14 18:30 ` Felipe Contreras [this message]
2012-05-14 19:09 ` Junio C Hamano
2012-05-14 19:53 ` Felipe Contreras
2012-05-15 17:01 ` Junio C Hamano
2012-05-15 17:03 ` Junio C Hamano
2012-05-16 15:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s1h=MPT8vx6JrGjMZWJzRjndxYKoYgo+1Y_Mmv+gWXzaQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).