From: David Aguilar <davvid@gmail.com>
To: Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
Cc: git@vger.kernel.org, Matthieu.Moy@grenoble-inp.fr,
NGUYEN Huynh Khoi Nguyen <nguyenhu@ensibm.imag.fr>,
Valentin Duperray <Valentin.Duperray@ensimag.imag.fr>,
Franck Jonas <Franck.Jonas@ensimag.imag.fr>,
Lucien Kong <Lucien.Kong@ensimag.imag.fr>,
Thomas Nguy <Thomas.Nguy@ensimag.imag.fr>
Subject: Re: [PATCHv6 4/4] Write to $XDG_CONFIG_HOME/git/config file
Date: Fri, 8 Jun 2012 20:48:49 -0700 [thread overview]
Message-ID: <CAJDDKr6sCrwy99-5-sOaAuNjYmnw73CicF3PyYMe8hvf38oFvg@mail.gmail.com> (raw)
In-Reply-To: <1338988885-21933-4-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
On Wed, Jun 6, 2012 at 6:21 AM, Huynh Khoi Nguyen NGUYEN
<Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> wrote:
> From: NGUYEN Huynh Khoi Nguyen <nguyenhu@ensibm.imag.fr>
>
> Git will be able to write to $XDG_CONFIG_HOME/git/config, a new
> configuration file following XDG specification, if:
> - this file already exists, and
> - $HOME/.gitconfig file doesn't, and
> - global option is used.
> Otherwise Git writes to $HOME/.gitconfig with global option, as usual.
> If you don't create $XDG_CONFIG_HOME/git/config, there is ABSOLUTELY
> NO change. Users can use this new file ONLY if they want.
> If $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/config
> will be used.
> Advice for users who often come back to an old version of GIT:
> you shouldn't create this file.
>
> Signed-off-by: Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
> Signed-off-by: Valentin Duperray <Valentin.Duperray@ensimag.imag.fr>
> Signed-off-by: Franck Jonas <Franck.Jonas@ensimag.imag.fr>
> Signed-off-by: Lucien Kong <Lucien.Kong@ensimag.imag.fr>
> Signed-off-by: Thomas Nguy <Thomas.Nguy@ensimag.imag.fr>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
> ---
I'm all for this change too.
I did a little research RE: the OSX and Windows question.
glib makes no differentiation between OSX and Linux,
but Windows does have its own #ifdef.
http://git.gnome.org/browse/glib/tree/glib/gutils.c#n1251
I certainly don't think this should affect this series,
I'm just noting it as something that the Windows folks might
care about. Perhaps something for compat/ in the future?
The downside to doing the same as glib is more documentation.
The upside is... consistency?
Thanks,
David
> Documentation/git-config.txt | 3 ++-
> builtin/config.c | 5 +----
> t/t1306-xdg-files.sh | 30 ++++++++++++++++++++++++++++++
> 3 files changed, 33 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index 7e344a2..a2b4786 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -97,7 +97,8 @@ OPTIONS
>
> --global::
> For writing options: write to global ~/.gitconfig file rather than
> - the repository .git/config.
> + the repository .git/config, write to $XDG_CONFIG_HOME/git/config file
> + if this file exists and ~/.gitconfig file doesn't.
> +
> For reading options: read only from global ~/.gitconfig and from
> $XDG_CONFIG_HOME/git/config rather than from all available files.
> diff --git a/builtin/config.c b/builtin/config.c
> index da54fd1..e8e1c0a 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -387,10 +387,7 @@ int cmd_config(int argc, const char **argv, const char *prefix)
>
> home_config_paths(&user_config, &xdg_config, "config");
>
> - if (access(user_config, R_OK) && !access(xdg_config, R_OK) &&
> - (actions == ACTION_LIST ||
> - actions == ACTION_GET_COLOR ||
> - actions == ACTION_GET_COLORBOOL))
> + if (access(user_config, R_OK) && !access(xdg_config, R_OK))
> given_config_file = xdg_config;
> else if (user_config)
> given_config_file = user_config;
> diff --git a/t/t1306-xdg-files.sh b/t/t1306-xdg-files.sh
> index eb0f40b..dbf236a 100755
> --- a/t/t1306-xdg-files.sh
> +++ b/t/t1306-xdg-files.sh
> @@ -154,4 +154,34 @@ test_expect_success 'Checking attributes in a non-XDG global attributes file' '
> '
>
>
> +test_expect_success 'write: xdg file exists and ~/.gitconfig doesn'\''t' '
> + mkdir -p .config/git &&
> + >.config/git/config &&
> + rm .gitconfig &&
> + git config --global user.name "write_config" &&
> + echo "[user]" >expected &&
> + echo " name = write_config" >>expected &&
> + test_cmp expected .config/git/config
> +'
> +
> +
> +test_expect_success 'write: xdg file exists and ~/.gitconfig exists' '
> + >.gitconfig &&
> + git config --global user.name "write_gitconfig" &&
> + echo "[user]" >expected &&
> + echo " name = write_gitconfig" >>expected &&
> + test_cmp expected .gitconfig
> +'
> +
> +
> +test_expect_success 'write: ~/.config/git/ exists and config file doesn'\''t' '
> + rm .gitconfig &&
> + rm .config/git/config &&
> + git config --global user.name "write_gitconfig" &&
> + echo "[user]" >expected &&
> + echo " name = write_gitconfig" >>expected &&
> + test_cmp expected .gitconfig
> +'
> +
> +
> test_done
> --
> 1.7.8
next prev parent reply other threads:[~2012-06-09 3:48 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1338400509-26087-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
2012-05-30 21:19 ` [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config Huynh Khoi Nguyen NGUYEN
2012-05-30 21:54 ` Junio C Hamano
2012-05-31 22:06 ` Ramsay Jones
2012-05-31 14:40 ` [PATCHv3] Read from XDG configuration file, not write Huynh Khoi Nguyen NGUYEN
2012-05-31 20:13 ` Junio C Hamano
2012-06-01 21:23 ` [PATCHv4] Read (but not write) from XDG configuration, XDG attributes and XDG ignore files Huynh Khoi Nguyen NGUYEN
2012-06-02 11:20 ` Matthieu Moy
2012-06-02 15:52 ` nguyenhu
2012-06-02 21:05 ` Matthieu Moy
2012-06-03 20:14 ` [PATCHv5 1/4] Read (but not write) from $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen NGUYEN
2012-06-03 20:14 ` [PATCHv5 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Huynh Khoi Nguyen NGUYEN
2012-06-04 11:43 ` Matthieu Moy
2012-06-05 13:17 ` nguyenhu
2012-06-03 20:14 ` [PATCHv5 3/4] Let core.attributesfile default to $XDG_CONFIG_HOME/git/attributes Huynh Khoi Nguyen NGUYEN
2012-06-03 20:14 ` [PATCHv5 4/4] Write to $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen NGUYEN
2012-06-04 21:17 ` Matthieu Moy
2012-06-05 13:04 ` nguyenhu
2012-06-06 13:21 ` [PATCHv6 1/4] Read (but not write) from " Huynh Khoi Nguyen NGUYEN
2012-06-06 13:21 ` [PATCHv6 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Huynh Khoi Nguyen NGUYEN
2012-06-07 23:31 ` Junio C Hamano
2012-06-08 8:47 ` Matthieu Moy
2012-06-08 9:02 ` nguyenhu
2012-06-06 13:21 ` [PATCHv6 3/4] Let core.attributesfile default to $XDG_CONFIG_HOME/git/attributes Huynh Khoi Nguyen NGUYEN
2012-06-06 13:21 ` [PATCHv6 4/4] Write to $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen NGUYEN
2012-06-09 3:48 ` David Aguilar [this message]
2012-06-09 6:19 ` Junio C Hamano
2012-06-09 17:25 ` David Aguilar
2012-06-10 13:21 ` Matthieu Moy
2012-06-11 23:45 ` nguyenhu
2012-06-07 22:58 ` [PATCHv6 1/4] Read (but not write) from " Junio C Hamano
2012-06-08 9:57 ` nguyenhu
2012-06-12 17:42 ` Ramsay Jones
2012-06-08 12:26 ` nguyenhu
2012-06-08 12:33 ` Erik Faye-Lund
2012-06-08 12:54 ` nguyenhu
2012-06-08 12:57 ` Erik Faye-Lund
2012-06-08 15:08 ` Junio C Hamano
2012-06-09 10:53 ` nguyenhu
2012-06-10 6:41 ` Junio C Hamano
2012-06-10 13:48 ` nguyenhu
2012-06-10 18:44 ` Erik Faye-Lund
2012-06-10 20:02 ` nguyenhu
2012-06-10 20:27 ` Erik Faye-Lund
2012-06-11 15:50 ` Junio C Hamano
2012-06-11 16:53 ` nguyenhu
2012-06-11 22:59 ` nguyenhu
2012-06-11 23:03 ` Erik Faye-Lund
2012-06-12 2:49 ` [PATCHv7 " Huynh Khoi Nguyen Nguyen
2012-06-12 2:49 ` [PATCHv7 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Huynh Khoi Nguyen Nguyen
2012-06-12 2:49 ` [PATCHv7 3/4] Let core.attributesfile default to $XDG_CONFIG_HOME/git/attributes Huynh Khoi Nguyen Nguyen
2012-06-12 2:49 ` [PATCHv7 4/4] Write to $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen Nguyen
2012-06-14 17:31 ` [PATCHv7 1/4] Read (but not write) from " Ramsay Jones
2012-06-21 16:55 ` Matthieu Moy
2012-06-21 17:22 ` Junio C Hamano
2012-06-22 9:03 ` [PATCH 0/4 v8] Git configuration directory Matthieu Moy
2012-06-22 9:03 ` [PATCH 1/4 v8] config: read (but not write) from $XDG_CONFIG_HOME/git/config file Matthieu Moy
2012-07-12 7:55 ` Thomas Rast
2012-07-12 12:04 ` [PATCH] config: fix several access(NULL) calls Matthieu Moy
2012-07-12 12:39 ` Thomas Rast
2012-07-12 17:14 ` Junio C Hamano
2012-07-12 19:34 ` Matthieu Moy
2012-07-12 20:12 ` Junio C Hamano
2012-07-13 8:48 ` Matthieu Moy
2012-07-13 8:59 ` [PATCH v2] " Matthieu Moy
2012-07-13 13:00 ` [PATCH] " Jeff King
2012-07-13 13:15 ` Matthieu Moy
2012-07-13 14:05 ` Thomas Rast
2012-07-13 14:23 ` Matthieu Moy
2012-07-13 16:49 ` Junio C Hamano
2012-07-16 9:45 ` Matthieu Moy
2012-07-16 16:35 ` Junio C Hamano
2012-07-16 16:39 ` Matthieu Moy
2012-07-16 16:56 ` Junio C Hamano
2012-06-22 9:03 ` [PATCH 2/4 v8] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Matthieu Moy
2012-06-22 9:03 ` [PATCH 3/4 v8] Let core.attributesfile " Matthieu Moy
2012-06-22 21:20 ` Junio C Hamano
2012-06-25 6:32 ` Matthieu Moy
2012-06-25 7:22 ` Junio C Hamano
2012-06-25 7:56 ` Matthieu Moy
2012-06-22 9:03 ` [PATCH 4/4 v8] config: write to $XDG_CONFIG_HOME/git/config file if appropriate Matthieu Moy
2012-06-22 21:20 ` Junio C Hamano
2012-06-25 6:45 ` Matthieu Moy
2012-06-25 18:08 ` Junio C Hamano
2012-06-22 21:19 ` [PATCH 0/4 v8] Git configuration directory Junio C Hamano
2012-06-04 17:54 ` [PATCHv4] Read (but not write) from XDG configuration, XDG attributes and XDG ignore files Ramsay Jones
2012-06-04 18:41 ` Junio C Hamano
2012-06-12 17:32 ` Ramsay Jones
2012-06-05 12:19 ` nguyenhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDDKr6sCrwy99-5-sOaAuNjYmnw73CicF3PyYMe8hvf38oFvg@mail.gmail.com \
--to=davvid@gmail.com \
--cc=Franck.Jonas@ensimag.imag.fr \
--cc=Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr \
--cc=Lucien.Kong@ensimag.imag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=Thomas.Nguy@ensimag.imag.fr \
--cc=Valentin.Duperray@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=nguyenhu@ensibm.imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).