From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Thomas Rast <trast@student.ethz.ch>, Jeff King <peff@peff.net>,
<git@vger.kernel.org>
Subject: Re: [PATCH] config: fix several access(NULL) calls
Date: Mon, 16 Jul 2012 09:35:11 -0700 [thread overview]
Message-ID: <7vipdn4qbk.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqmx3011la.fsf@bauges.imag.fr> (Matthieu Moy's message of "Mon, 16 Jul 2012 11:45:21 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> if (use_global_config) {
>> if (is $HOME/.gitconfig usable?) {
>> use it;
>
> Yes, but when $HOME is unset, the question doesn't really make sense.
> Maybe the file exists, but we can't know since the user broke his
> configuration by unsetting $HOME. The intent was to avoid writing to the
> XDG file unless it was very clear that the user wanted it, so in doubt,
> dying seems the best option.
I would think that it is plausible that the user wanted to write
into XDG one and used "unset HOME" as a way to signal that wish.
Are there ways to force writing into XDG ones without having to
remove the $HOME/ ones (perhaps the user wants to keep them for use
with older versions of Git on a different machine that shares the
same $HOME directory)? Temporarily unsetting HOME may be how a user
might achieve it.
If you want to disallow such a use case, that is fine, but at least
the logic needs to be described in comment. Perhaps based on one of
your rewrites earlier in the thread, like this?
builtin/config.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/builtin/config.c b/builtin/config.c
index 67945b2..a788409 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -387,13 +387,26 @@ int cmd_config(int argc, const char **argv, const char *prefix)
home_config_paths(&user_config, &xdg_config, "config");
- if (user_config && access(user_config, R_OK) &&
+ if (!user_config)
+ /*
+ * We do not know HOME/.gitconfig exists or
+ * not, hence we do not know if we should
+ * write to XDG location, so we error out even
+ * if XDG_CONFIG_HOME is set and points at a
+ * sane location.
+ *
+ * In other words, we forbid the user from
+ * telling us to write to XDG location,
+ * pretending that $HOME/.gitconfig does not
+ * exist, by temporarily unsetting HOME.
+ */
+ die("$HOME not set");
+
+ if (access(user_config, R_OK) &&
xdg_config && !access(xdg_config, R_OK))
given_config_file = xdg_config;
- else if (user_config)
- given_config_file = user_config;
else
- die("$HOME not set");
+ given_config_file = user_config;
}
else if (use_system_config)
given_config_file = git_etc_gitconfig();
next prev parent reply other threads:[~2012-07-16 16:35 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1338400509-26087-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
2012-05-30 21:19 ` [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config Huynh Khoi Nguyen NGUYEN
2012-05-30 21:54 ` Junio C Hamano
2012-05-31 22:06 ` Ramsay Jones
2012-05-31 14:40 ` [PATCHv3] Read from XDG configuration file, not write Huynh Khoi Nguyen NGUYEN
2012-05-31 20:13 ` Junio C Hamano
2012-06-01 21:23 ` [PATCHv4] Read (but not write) from XDG configuration, XDG attributes and XDG ignore files Huynh Khoi Nguyen NGUYEN
2012-06-02 11:20 ` Matthieu Moy
2012-06-02 15:52 ` nguyenhu
2012-06-02 21:05 ` Matthieu Moy
2012-06-03 20:14 ` [PATCHv5 1/4] Read (but not write) from $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen NGUYEN
2012-06-03 20:14 ` [PATCHv5 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Huynh Khoi Nguyen NGUYEN
2012-06-04 11:43 ` Matthieu Moy
2012-06-05 13:17 ` nguyenhu
2012-06-03 20:14 ` [PATCHv5 3/4] Let core.attributesfile default to $XDG_CONFIG_HOME/git/attributes Huynh Khoi Nguyen NGUYEN
2012-06-03 20:14 ` [PATCHv5 4/4] Write to $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen NGUYEN
2012-06-04 21:17 ` Matthieu Moy
2012-06-05 13:04 ` nguyenhu
2012-06-06 13:21 ` [PATCHv6 1/4] Read (but not write) from " Huynh Khoi Nguyen NGUYEN
2012-06-06 13:21 ` [PATCHv6 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Huynh Khoi Nguyen NGUYEN
2012-06-07 23:31 ` Junio C Hamano
2012-06-08 8:47 ` Matthieu Moy
2012-06-08 9:02 ` nguyenhu
2012-06-06 13:21 ` [PATCHv6 3/4] Let core.attributesfile default to $XDG_CONFIG_HOME/git/attributes Huynh Khoi Nguyen NGUYEN
2012-06-06 13:21 ` [PATCHv6 4/4] Write to $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen NGUYEN
2012-06-09 3:48 ` David Aguilar
2012-06-09 6:19 ` Junio C Hamano
2012-06-09 17:25 ` David Aguilar
2012-06-10 13:21 ` Matthieu Moy
2012-06-11 23:45 ` nguyenhu
2012-06-07 22:58 ` [PATCHv6 1/4] Read (but not write) from " Junio C Hamano
2012-06-08 9:57 ` nguyenhu
2012-06-12 17:42 ` Ramsay Jones
2012-06-08 12:26 ` nguyenhu
2012-06-08 12:33 ` Erik Faye-Lund
2012-06-08 12:54 ` nguyenhu
2012-06-08 12:57 ` Erik Faye-Lund
2012-06-08 15:08 ` Junio C Hamano
2012-06-09 10:53 ` nguyenhu
2012-06-10 6:41 ` Junio C Hamano
2012-06-10 13:48 ` nguyenhu
2012-06-10 18:44 ` Erik Faye-Lund
2012-06-10 20:02 ` nguyenhu
2012-06-10 20:27 ` Erik Faye-Lund
2012-06-11 15:50 ` Junio C Hamano
2012-06-11 16:53 ` nguyenhu
2012-06-11 22:59 ` nguyenhu
2012-06-11 23:03 ` Erik Faye-Lund
2012-06-12 2:49 ` [PATCHv7 " Huynh Khoi Nguyen Nguyen
2012-06-12 2:49 ` [PATCHv7 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Huynh Khoi Nguyen Nguyen
2012-06-12 2:49 ` [PATCHv7 3/4] Let core.attributesfile default to $XDG_CONFIG_HOME/git/attributes Huynh Khoi Nguyen Nguyen
2012-06-12 2:49 ` [PATCHv7 4/4] Write to $XDG_CONFIG_HOME/git/config file Huynh Khoi Nguyen Nguyen
2012-06-14 17:31 ` [PATCHv7 1/4] Read (but not write) from " Ramsay Jones
2012-06-21 16:55 ` Matthieu Moy
2012-06-21 17:22 ` Junio C Hamano
2012-06-22 9:03 ` [PATCH 0/4 v8] Git configuration directory Matthieu Moy
2012-06-22 9:03 ` [PATCH 1/4 v8] config: read (but not write) from $XDG_CONFIG_HOME/git/config file Matthieu Moy
2012-07-12 7:55 ` Thomas Rast
2012-07-12 12:04 ` [PATCH] config: fix several access(NULL) calls Matthieu Moy
2012-07-12 12:39 ` Thomas Rast
2012-07-12 17:14 ` Junio C Hamano
2012-07-12 19:34 ` Matthieu Moy
2012-07-12 20:12 ` Junio C Hamano
2012-07-13 8:48 ` Matthieu Moy
2012-07-13 8:59 ` [PATCH v2] " Matthieu Moy
2012-07-13 13:00 ` [PATCH] " Jeff King
2012-07-13 13:15 ` Matthieu Moy
2012-07-13 14:05 ` Thomas Rast
2012-07-13 14:23 ` Matthieu Moy
2012-07-13 16:49 ` Junio C Hamano
2012-07-16 9:45 ` Matthieu Moy
2012-07-16 16:35 ` Junio C Hamano [this message]
2012-07-16 16:39 ` Matthieu Moy
2012-07-16 16:56 ` Junio C Hamano
2012-06-22 9:03 ` [PATCH 2/4 v8] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Matthieu Moy
2012-06-22 9:03 ` [PATCH 3/4 v8] Let core.attributesfile " Matthieu Moy
2012-06-22 21:20 ` Junio C Hamano
2012-06-25 6:32 ` Matthieu Moy
2012-06-25 7:22 ` Junio C Hamano
2012-06-25 7:56 ` Matthieu Moy
2012-06-22 9:03 ` [PATCH 4/4 v8] config: write to $XDG_CONFIG_HOME/git/config file if appropriate Matthieu Moy
2012-06-22 21:20 ` Junio C Hamano
2012-06-25 6:45 ` Matthieu Moy
2012-06-25 18:08 ` Junio C Hamano
2012-06-22 21:19 ` [PATCH 0/4 v8] Git configuration directory Junio C Hamano
2012-06-04 17:54 ` [PATCHv4] Read (but not write) from XDG configuration, XDG attributes and XDG ignore files Ramsay Jones
2012-06-04 18:41 ` Junio C Hamano
2012-06-12 17:32 ` Ramsay Jones
2012-06-05 12:19 ` nguyenhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vipdn4qbk.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).