Re: [PATCHv5 4/4] Write to $XDG_CONFIG_HOME/git/config file

[nguyenhu@minatec.inpg.fr]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=";"; format=flowed	DelSp=Yes, Size: 1068 bytes --]


Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> a écrit :

> Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
> writes:
>
>> +test_expect_success 'write: xdg file exists and ~/.gitconfig doesn'\''t' '
>> +	mkdir -p .config/git &&
>> +	>.config/git/config &&
>> +	rm .gitconfig &&
>> +	git config --global user.name "write_config" &&
>> +	echo "[user]" >expected &&
>> +	echo "	name = write_config" >>expected &&
>> +	test_cmp expected .config/git/config
>> +'
>
> It was suggested that you also write to the XDG file if the XDG
> _directory_ exists. After thinking about it, I tend to disagree with
> this, because creating ~/.config/git/ignore would let Git write to the
> XDG configuration file as a side effect, which I find strange.
>
> Anyway, you may add the case where ~/.config/git/ exists but not the
> config file in it to your tests, to materialize the decision you have
> taken on that point.
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/

I agree. This case will be added in our next v6 version.