From: Stefan Beller <sbeller@google.com>
To: Jeff King <peff@peff.net>
Cc: vi0oss <vi0oss@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Stefan Beller <stefanbeller@gmail.com>
Subject: Re: [PATCH] submodule--helper: set alternateLocation for cloned submodules
Date: Thu, 8 Dec 2016 10:04:03 -0800 [thread overview]
Message-ID: <CAGZ79kbbi1J3BgQF-Ws0Ud-4h9efuQJTdsiA7Skh1fZXH5xqgg@mail.gmail.com> (raw)
In-Reply-To: <20161208174633.bsktiflql6jpn5t3@sigill.intra.peff.net>
On Thu, Dec 8, 2016 at 9:46 AM, Jeff King <peff@peff.net> wrote:
>
> will both trigger on the &&-chain linter, because it uses a magic exit
> code to detect the breakage. I think the problem is just that the
> &&-chain linter cannot peek inside subshells, and that's where the bug
> was in this case.
Uh, yeah in the subshell, but the patch v2 did have it not in
subshells, I'll take another look.
>
> I wish we could improve that, but I spend a lot of brain cycles on it at
> one point and couldn't come up with a workable solution.
Is it possible to overwrite what happens when you open a subshell with ( ) ?
i.e. I imagine in the global test-setup we'd setup that ( ) not just
opens /bin/sh
but a shell with benefits such that we can execute just one && chain.
next prev parent reply other threads:[~2016-12-08 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 0:39 [PATCH] submodule--helper: set alternateLocation for cloned submodules vi0oss
2016-12-08 1:22 ` Stefan Beller
2016-12-08 17:46 ` Jeff King
2016-12-08 18:04 ` Stefan Beller [this message]
2016-12-08 18:04 ` vi0oss
2016-12-08 18:21 ` Stefan Beller
2016-12-08 18:53 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2016-12-12 2:45 vi0oss
2016-12-08 1:38 vi0oss
2016-12-10 13:41 ` vi0oss
2016-12-12 5:35 ` Stefan Beller
2016-12-12 18:00 ` Junio C Hamano
2016-12-07 18:42 vi0oss
2016-12-07 20:09 ` Stefan Beller
2016-12-07 20:18 ` Junio C Hamano
2016-12-07 20:26 ` Stefan Beller
2016-12-07 20:28 ` Junio C Hamano
2016-12-07 21:24 ` vi0oss
2016-12-07 22:09 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kbbi1J3BgQF-Ws0Ud-4h9efuQJTdsiA7Skh1fZXH5xqgg@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stefanbeller@gmail.com \
--cc=vi0oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).