From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: vi0oss <vi0oss@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Stefan Beller <stefanbeller@gmail.com>
Subject: Re: [PATCH] submodule--helper: set alternateLocation for cloned submodules
Date: Thu, 8 Dec 2016 12:46:33 -0500 [thread overview]
Message-ID: <20161208174633.bsktiflql6jpn5t3@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kZU401JRp4EtwTGHzk3Zq+snQhX3GArDfF6SpKxsSwtWg@mail.gmail.com>
On Wed, Dec 07, 2016 at 05:22:30PM -0800, Stefan Beller wrote:
> On Wed, Dec 7, 2016 at 4:39 PM, <vi0oss@gmail.com> wrote:
>
> >
> > Previously test contained errorneous
> > test_must_fail, which was masked by
> > missing &&.
>
> I wonder if we could make either
> the test_must_fail intelligent to detect such a broken && call chain
> or the test_expect_success macro to see for those broken chains.
I don't think test_must_fail is relevant for &&-chains. Even something
like:
test_must_fail foo
bar
or:
bar
test_must_fail foo
will both trigger on the &&-chain linter, because it uses a magic exit
code to detect the breakage. I think the problem is just that the
&&-chain linter cannot peek inside subshells, and that's where the bug
was in this case.
I wish we could improve that, but I spend a lot of brain cycles on it at
one point and couldn't come up with a workable solution.
-Peff
next prev parent reply other threads:[~2016-12-08 17:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 0:39 [PATCH] submodule--helper: set alternateLocation for cloned submodules vi0oss
2016-12-08 1:22 ` Stefan Beller
2016-12-08 17:46 ` Jeff King [this message]
2016-12-08 18:04 ` Stefan Beller
2016-12-08 18:04 ` vi0oss
2016-12-08 18:21 ` Stefan Beller
2016-12-08 18:53 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2016-12-12 2:45 vi0oss
2016-12-08 1:38 vi0oss
2016-12-10 13:41 ` vi0oss
2016-12-12 5:35 ` Stefan Beller
2016-12-12 18:00 ` Junio C Hamano
2016-12-07 18:42 vi0oss
2016-12-07 20:09 ` Stefan Beller
2016-12-07 20:18 ` Junio C Hamano
2016-12-07 20:26 ` Stefan Beller
2016-12-07 20:28 ` Junio C Hamano
2016-12-07 21:24 ` vi0oss
2016-12-07 22:09 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208174633.bsktiflql6jpn5t3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
--cc=stefanbeller@gmail.com \
--cc=vi0oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).