From: Stefan Beller <sbeller@google.com>
To: vi0oss <vi0oss@gmail.com>
Cc: Jeff King <peff@peff.net>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Stefan Beller <stefanbeller@gmail.com>
Subject: Re: [PATCH] submodule--helper: set alternateLocation for cloned submodules
Date: Thu, 8 Dec 2016 10:21:51 -0800 [thread overview]
Message-ID: <CAGZ79kZs4vy3-1jAxY+95CNRE2_YgTcBTsxR-Mg0xLqCp7UHcA@mail.gmail.com> (raw)
In-Reply-To: <d445a6c3-5375-22cf-4f03-1717559f1157@gmail.com>
On Thu, Dec 8, 2016 at 10:04 AM, vi0oss <vi0oss@gmail.com> wrote:
> On 12/08/2016 08:46 PM, Jeff King wrote:
>>
>> On Wed, Dec 07, 2016 at 05:22:30PM -0800, Stefan Beller wrote:
>>
>>> On Wed, Dec 7, 2016 at 4:39 PM, <vi0oss@gmail.com> wrote:
>>>
>>>> Previously test contained errorneous
>>>> test_must_fail, which was masked by
>>>> missing &&.
>>>
>>> I wonder if we could make either
>>> the test_must_fail intelligent to detect such a broken && call chain
>>> or the test_expect_success macro to see for those broken chains.
>>>
>>>
>>> I wish we could improve that, but I spend a lot of brain cycles on it at
>>> one point and couldn't come up with a workable solution.
>>>
>>> -Peff
>>>
> Why Git test use &&-chains instead of proper "set -e"?
>
"Because set -e kills the shell and we would want to keep going
until the test suite is finished and display a summary what failed"
would be my first reaction, but let's dig into history:
bb79af9d09 might be helpful on that, but it doesn't explain why
we use && chains.
I could not find any commit explaining the use of && chains.
e1970ce43abf might be interesting (the introduction of the test
suite), as that did not contain && chains.
I guess it would be hard(er) to implement e.g. test_must_fail
in an environment where -e is set.
next prev parent reply other threads:[~2016-12-08 18:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 0:39 [PATCH] submodule--helper: set alternateLocation for cloned submodules vi0oss
2016-12-08 1:22 ` Stefan Beller
2016-12-08 17:46 ` Jeff King
2016-12-08 18:04 ` Stefan Beller
2016-12-08 18:04 ` vi0oss
2016-12-08 18:21 ` Stefan Beller [this message]
2016-12-08 18:53 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2016-12-12 2:45 vi0oss
2016-12-08 1:38 vi0oss
2016-12-10 13:41 ` vi0oss
2016-12-12 5:35 ` Stefan Beller
2016-12-12 18:00 ` Junio C Hamano
2016-12-07 18:42 vi0oss
2016-12-07 20:09 ` Stefan Beller
2016-12-07 20:18 ` Junio C Hamano
2016-12-07 20:26 ` Stefan Beller
2016-12-07 20:28 ` Junio C Hamano
2016-12-07 21:24 ` vi0oss
2016-12-07 22:09 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZs4vy3-1jAxY+95CNRE2_YgTcBTsxR-Mg0xLqCp7UHcA@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stefanbeller@gmail.com \
--cc=vi0oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).