From: John Szakmeister <john@szakmeister.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: The config include mechanism doesn't allow for overwriting
Date: Tue, 23 Oct 2012 20:46:47 -0400 [thread overview]
Message-ID: <CAEBDL5V0Ffyp306rVo-USCBy_AXXMHXN1yrWmkF1BhzFaq60nA@mail.gmail.com> (raw)
In-Reply-To: <CACBZZX5mOb7_i9r8AqNK5V3r-gVnzN+rkeY9xrhecGv1rS-anA@mail.gmail.com>
On Tue, Oct 23, 2012 at 10:13 AM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
[snip]
> And git config --get foo.bar will give you:
>
> $ git config -f /tmp/test --get foo.bar
> one
> error: More than one value for the key foo.bar: two
> error: More than one value for the key foo.bar: three
>
> I think that it would be better if the config mechanism just silently
> overwrote keys that clobbered earlier keys like your patch does.
>
> But in addition can we simplify things for the consumers of
> "git-{config,var} -l" by only printing:
>
> foo.bar=three
>
> Or are there too many variables like "include.path" that can
> legitimately appear more than once.
I frequently use pushurl in my remotes to push my master branch both
to the original repo and my forked version. I find it very helpful in
my workflow, and would hate to lose that. That said, I do like the
idea of having a config file and the ability to override some of the
variables.
-John
next prev parent reply other threads:[~2012-10-24 0:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 15:55 The config include mechanism doesn't allow for overwriting Ævar Arnfjörð Bjarmason
2012-10-22 21:15 ` Jeff King
2012-10-23 14:13 ` Ævar Arnfjörð Bjarmason
2012-10-23 22:35 ` [PATCH 0/8] fix git-config with duplicate variable entries Jeff King
2012-10-23 22:35 ` [PATCH 1/8] t1300: style updates Jeff King
2012-10-24 6:33 ` Johannes Sixt
2012-10-24 6:37 ` Jeff King
2012-10-24 7:07 ` [PATCHv2 " Jeff King
2012-10-23 22:36 ` [PATCH 2/8] t1300: remove redundant test Jeff King
2012-10-23 22:36 ` [PATCH 3/8] t1300: test "git config --get-all" more thoroughly Jeff King
2012-10-23 22:36 ` [PATCH 4/8] git-config: remove memory leak of key regexp Jeff King
2012-10-23 22:38 ` [PATCH 5/8] git-config: fix regexp memory leaks on error conditions Jeff King
2012-10-23 22:40 ` [PATCH 6/8] git-config: collect values instead of immediately printing Jeff King
2012-10-23 22:41 ` [PATCH 7/8] git-config: do not complain about duplicate entries Jeff King
2012-10-23 22:41 ` [PATCH 8/8] git-config: use git_config_with_options Jeff King
2012-10-24 6:33 ` Johannes Sixt
2012-10-24 19:14 ` Ævar Arnfjörð Bjarmason
2012-11-20 19:08 ` [PATCH 0/8] fix git-config with duplicate variable entries Junio C Hamano
2012-11-21 19:27 ` Jeff King
2012-11-21 19:46 ` Junio C Hamano
2012-11-21 20:06 ` Jeff King
2012-11-21 20:42 ` Junio C Hamano
2012-11-23 10:37 ` Joachim Schmitz
2012-10-24 0:46 ` John Szakmeister [this message]
2012-10-24 0:51 ` The config include mechanism doesn't allow for overwriting Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEBDL5V0Ffyp306rVo-USCBy_AXXMHXN1yrWmkF1BhzFaq60nA@mail.gmail.com \
--to=john@szakmeister.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).