From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH 0/8] fix git-config with duplicate variable entries
Date: Tue, 20 Nov 2012 11:08:43 -0800 [thread overview]
Message-ID: <7vsj84rt1g.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121023223502.GA23194@sigill.intra.peff.net> (Jeff King's message of "Tue, 23 Oct 2012 18:35:02 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, Oct 23, 2012 at 04:13:44PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> > It fails a few tests in t1300, but it looks like those tests are testing
>> > for the behavior we have identified as wrong, and should be fixed.
>>
>> I think this patch looks good.
>
> Thanks. It had a few minor flaws (like a memory leak). I fixed those,
> updated the tests, and split it out into a few more readable commits. In
> the process, I managed to uncover and fix a few other memory leaks in
> the area. I think this version is much more readable, and writing the
> rationale for patch 7 convinced me that it's the right thing to do.
> Another round of review would be appreciated.
>
> [1/8]: t1300: style updates
> [2/8]: t1300: remove redundant test
> [3/8]: t1300: test "git config --get-all" more thoroughly
> [4/8]: git-config: remove memory leak of key regexp
> [5/8]: git-config: fix regexp memory leaks on error conditions
> [6/8]: git-config: collect values instead of immediately printing
> [7/8]: git-config: do not complain about duplicate entries
> [8/8]: git-config: use git_config_with_options
>
> For those just joining us, the interesting bit is patch 7, which fixes
> some inconsistencies between the "git-config" tool and how the internal
> config callbacks work.
The way for the Porcelain scripts to mimick the internal "last one
wins" has been to grab values out of --get-all and do the "last one
wins" themselves, and I agree that a mode that frees them from
having to worry about it is a good *addition*. I would even say
that if we were designing "git config" plumbing without existing
users, it would be the only sensible behaviour for "--get".
But "git config --get" users have been promised to get errors on
duplicate values so far, so I have to say this needs to come with a
big red sign about API breakage.
I would feel safer to introduce --get-one or something now, and
worry about migration as a separate step.
next prev parent reply other threads:[~2012-11-20 19:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 15:55 The config include mechanism doesn't allow for overwriting Ævar Arnfjörð Bjarmason
2012-10-22 21:15 ` Jeff King
2012-10-23 14:13 ` Ævar Arnfjörð Bjarmason
2012-10-23 22:35 ` [PATCH 0/8] fix git-config with duplicate variable entries Jeff King
2012-10-23 22:35 ` [PATCH 1/8] t1300: style updates Jeff King
2012-10-24 6:33 ` Johannes Sixt
2012-10-24 6:37 ` Jeff King
2012-10-24 7:07 ` [PATCHv2 " Jeff King
2012-10-23 22:36 ` [PATCH 2/8] t1300: remove redundant test Jeff King
2012-10-23 22:36 ` [PATCH 3/8] t1300: test "git config --get-all" more thoroughly Jeff King
2012-10-23 22:36 ` [PATCH 4/8] git-config: remove memory leak of key regexp Jeff King
2012-10-23 22:38 ` [PATCH 5/8] git-config: fix regexp memory leaks on error conditions Jeff King
2012-10-23 22:40 ` [PATCH 6/8] git-config: collect values instead of immediately printing Jeff King
2012-10-23 22:41 ` [PATCH 7/8] git-config: do not complain about duplicate entries Jeff King
2012-10-23 22:41 ` [PATCH 8/8] git-config: use git_config_with_options Jeff King
2012-10-24 6:33 ` Johannes Sixt
2012-10-24 19:14 ` Ævar Arnfjörð Bjarmason
2012-11-20 19:08 ` Junio C Hamano [this message]
2012-11-21 19:27 ` [PATCH 0/8] fix git-config with duplicate variable entries Jeff King
2012-11-21 19:46 ` Junio C Hamano
2012-11-21 20:06 ` Jeff King
2012-11-21 20:42 ` Junio C Hamano
2012-11-23 10:37 ` Joachim Schmitz
2012-10-24 0:46 ` The config include mechanism doesn't allow for overwriting John Szakmeister
2012-10-24 0:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsj84rt1g.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).