Re: [GSoC][PATCH 1/2] t4131: modernize style

[Harshit Jain <harshitjain1371999@gmail.com>]

Hi Shourya,

> > The tests in 't4131-apply-fake-ancestor.sh' were written a long time ago, and have a few style violations. Update it to adhere to the CodingGuidelines.
>
> Maybe add a commit title and then have a body? To do so, do a 'git commit' instead of 'git commit -m "message"'. This will open a text editor
> in which you can edit your commit message. You may refer to this answer I gave on StackOverflow on commit messages:
>
> https://stackoverflow.com/a/60755299/10751129

I used 'git commit' only and not 'git commit -m "message". But
apparently, the git format-patch tool takes the first line of commit
message i.e. the
commit title as the file name and the lines after that as the text for
the body. And hence, the patch emails, just start with the commit
description
and not the commit title.

So, should I explicitly add the commit title in the patch files
generated or else how to handle this?

> Also, commit messages are generally around 72 characters per line. What are the
> style violations you are talking about BTW?

The git coding guidelines says that we shouldn't have a space after
the redirection operators, hence I corrected this in the test file.

Regards,
Harshit Jain