From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>,
harshitjain1371999@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>
Date: Thu, 19 Mar 2020 23:03:24 +0530 [thread overview]
Message-ID: <555da203-0740-3d79-15cf-83c5a8d5dbae@gmail.com> (raw)
In-Reply-To: <20200319164234.4441-1-shouryashukla.oo@gmail.com>
On 19-03-2020 22:12, Shourya Shukla wrote:
> Hello Harshit,
>
>> Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.
>
> Again the same thing, you may follow what I stated before regarding commit messages.
>
> The commit title can be of the form:
>
> t4131: use helpers to replace test -f <path>
>
> <<commit description>>
>
Just curious, isn't the commit title already like that in this patch?
The subject does read:
[GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>"
What am I missing?
--
Sivaraam
next prev parent reply other threads:[~2020-03-19 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 13:29 [GSoC][Patch 0/2] t4131: update test script Harshit Jain
2020-03-19 13:29 ` [GSoC][PATCH 1/2] t4131: modernize style Harshit Jain
2020-03-19 16:38 ` Shourya Shukla
2020-03-19 17:45 ` Harshit Jain
2020-03-19 21:55 ` Junio C Hamano
2020-03-19 13:29 ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Harshit Jain
2020-03-19 16:42 ` Shourya Shukla
2020-03-19 17:33 ` Kaartic Sivaraam [this message]
2020-03-19 20:18 ` Harshit Jain
2020-03-20 15:39 ` Re: RFC][Feature] submodule Shourya Shukla
2020-03-19 21:58 ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Junio C Hamano
2020-03-20 13:08 ` [GSoC][Patch 0/2] made the changes as per community suggestions Harshit Jain
2020-03-20 13:08 ` [PATCH 1/2] t4131: modernize style Harshit Jain
2020-03-20 15:56 ` Re: [GSoC][Patch] Shourya Shukla
2020-03-20 17:14 ` Harshit Jain
2020-03-20 13:08 ` [PATCH 2/2] t4131: use helper function to replace 'test -f' Harshit Jain
2020-03-20 15:43 ` Re: [GSoC][Patch] Shourya Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555da203-0740-3d79-15cf-83c5a8d5dbae@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git@vger.kernel.org \
--cc=harshitjain1371999@gmail.com \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).