mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Harshit Jain <>
To: Shourya Shukla <>
Subject: Re: Re: [GSoC][Patch]
Date: Fri, 20 Mar 2020 22:44:09 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Shourya,

On Fri, Mar 20, 2020 at 9:26 PM Shourya Shukla
<> wrote:
> Hello Harshit,
> > The tests in t4131 leave a space character between the redirection operator
> > and the file i.e. the redirection target which does not conform to the
> > modern coding style.
> > Fix them.
> I think something like,
> The tests in t4131 were written a long time ago and hence contain style violations
> such as an extra space between the redirection operator(>) and the redirection target.
> Update it to match the latest CodingGuidelines.
> may be better.

Please see the comment made by Junio Hamano, pasted below:

"written a long time ago" does not have much value by itself (it
does serve as a backstory to explain a half of why it does not use
the more modern style, though).  "have a few style violations." is
almost meaningless (otherwise, you would not be doing a "modernize
style" patch in the first place ;-).

I myself also agree with the above comment and hence, wrote the commit message
accordingly. What do you think?

> Also, when you deliver a newer version of the patch, i.e., version 2 in your case,
> you have a [PATCH v2 1/n] as the subject, so that people know that it is the v2 and
> hence avoid confusion.
> If you are using 'git format-patch' to formulate your mails, you can do:
> 'git format-patch -v2 <..>' to get a v2 based mail.

Oh nice, didn't know about this. I will keep this in mind for future
patch submissions.
Should I do this for the current patch as well?

Harshit Jain

  reply	other threads:[~2020-03-20 17:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 13:29 [GSoC][Patch 0/2] t4131: update test script Harshit Jain
2020-03-19 13:29 ` [GSoC][PATCH 1/2] t4131: modernize style Harshit Jain
2020-03-19 16:38   ` Shourya Shukla
2020-03-19 17:45     ` Harshit Jain
2020-03-19 21:55       ` Junio C Hamano
2020-03-19 13:29 ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Harshit Jain
2020-03-19 16:42   ` Shourya Shukla
2020-03-19 17:33     ` Kaartic Sivaraam
2020-03-19 20:18       ` Harshit Jain
2020-03-20 15:39       ` Re: RFC][Feature] submodule Shourya Shukla
2020-03-19 21:58     ` [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path> Junio C Hamano
2020-03-20 13:08       ` [GSoC][Patch 0/2] made the changes as per community suggestions Harshit Jain
2020-03-20 13:08         ` [PATCH 1/2] t4131: modernize style Harshit Jain
2020-03-20 15:56           ` Re: [GSoC][Patch] Shourya Shukla
2020-03-20 17:14             ` Harshit Jain [this message]
2020-03-20 13:08         ` [PATCH 2/2] t4131: use helper function to replace 'test -f' Harshit Jain
2020-03-20 15:43       ` Re: [GSoC][Patch] Shourya Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).